Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: chrome/browser/ui/webui/BidiCheckerWebUITest.cc

Issue 7068007: Revise about: and chrome: url handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update special_tabs.py from Nirnimesh's codereview.chromium.org/6995057/. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/BidiCheckerWebUITest.h" 5 #include "chrome/browser/ui/webui/BidiCheckerWebUITest.h"
6 6
7 #include "base/base_paths.h" 7 #include "base/base_paths.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 const GURL history_url = GURL("http://www.ynet.co.il"); 56 const GURL history_url = GURL("http://www.ynet.co.il");
57 history_service->AddPage(history_url, history::SOURCE_BROWSED); 57 history_service->AddPage(history_url, history::SOURCE_BROWSED);
58 string16 title; 58 string16 title;
59 ASSERT_TRUE(UTF8ToUTF16("\xD7\x91\xD7\x93\xD7\x99\xD7\xA7\xD7\x94\x21", 59 ASSERT_TRUE(UTF8ToUTF16("\xD7\x91\xD7\x93\xD7\x99\xD7\xA7\xD7\x94\x21",
60 12, 60 12,
61 &title)); 61 &title));
62 history_service->SetPageTitle(history_url, title); 62 history_service->SetPageTitle(history_url, title);
63 RunBidiCheckerOnPage(chrome::kChromeUIHistoryURL, false); 63 RunBidiCheckerOnPage(chrome::kChromeUIHistoryURL, false);
64 } 64 }
65 65
66 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTest, TestAboutAboutPageLTR) {\
67 RunBidiCheckerOnPage(chrome::kChromeUIAboutAboutURL, false);\
68 }
69
70 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTest, TestAboutPageLTR) {\ 66 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTest, TestAboutPageLTR) {\
71 RunBidiCheckerOnPage(chrome::kChromeUIAboutURL, false);\ 67 RunBidiCheckerOnPage(chrome::kChromeUIAboutURL, false);\
72 } 68 }
73 69
74 // Times out. http://code.google.com/p/chromium/issues/detail?id=82896 70 // Times out. http://code.google.com/p/chromium/issues/detail?id=82896
75 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTest, 71 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTest,
76 DISABLED_TestBookmarksPageLTR) {\ 72 DISABLED_TestBookmarksPageLTR) {\
77 RunBidiCheckerOnPage(chrome::kChromeUIBookmarksURL, false);\ 73 RunBidiCheckerOnPage(chrome::kChromeUIBookmarksURL, false);\
78 } 74 }
79 75
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 "0000"); 121 "0000");
126 122
127 PersonalDataManager* personal_data_manager = 123 PersonalDataManager* personal_data_manager =
128 browser()->profile()->GetPersonalDataManager(); 124 browser()->profile()->GetPersonalDataManager();
129 ASSERT_TRUE(personal_data_manager); 125 ASSERT_TRUE(personal_data_manager);
130 126
131 personal_data_manager->AddProfile(profile); 127 personal_data_manager->AddProfile(profile);
132 128
133 RunBidiCheckerOnPage(url.c_str(), false); 129 RunBidiCheckerOnPage(url.c_str(), false);
134 } 130 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/gtk/browser_toolbar_gtk.cc ('k') | chrome/browser/ui/webui/chrome_url_data_manager_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698