Issue 7067045: Disable QuotaMananger tests which rely on precise time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7067045: Disable QuotaMananger tests which rely on precise time. (Closed)

Created:
9 years, 7 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
kinuko, commit-bot: I haz the power

CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Disable QuotaMananger tests which rely on precise time. The tests were storing time values in SQLite, and different inserts were all the same. Previous version of SQLite was returning them in the order inserted (test succeeded), current version returns a different order (test fails). TBR=kinuko@chromium.org BUG=83805 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86553

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	webkit/quota/quota_manager_unittest.cc	View		2 chunks	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

kinuko, I'm TBR'ing this to you, because it's blocking me on something which is blocking ...

9 years, 7 months ago (2011-05-24 23:27:58 UTC) #1

No LGTM from valid reviewers yet.

Expand Messages | Collapse Messages