Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 7067043: ntp4: break navigation dots into own class. (Closed)

Created:
9 years, 7 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
csilv
CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

ntp4: break navigation dots into own class. BUG=none TEST=dragging onto dots works still, clicking on dots works still Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -133 lines) Patch
M chrome/browser/resources/ntp4/apps_page.js View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/ntp4/most_visited_page.js View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/browser/resources/ntp4/nav_dot.js View 1 chunk +116 lines, -0 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.html View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.js View 9 chunks +11 lines, -43 lines 0 comments Download
M chrome/browser/resources/ntp4/tile_page.js View 12 chunks +20 lines, -84 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
9 years, 7 months ago (2011-05-24 22:24:04 UTC) #1
csilv
9 years, 7 months ago (2011-05-25 00:38:26 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698