Options: Remove the hidden class, since we override the hidden attribute to set

chrome/browser/resources/options/personal_options.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   var OptionsPage = options.OptionsPage;
 
   // State variables.
   var syncEnabled = false;
@@ skipping 96 matching lines @@
     },
 
     showStopSyncingOverlay_: function() {
       AlertOverlay.show(localStrings.getString('stop_syncing_title'),
                         localStrings.getString('stop_syncing_explanation'),
                         localStrings.getString('stop_syncing_confirm'),
                         localStrings.getString('cancel'),
                         function() { chrome.send('stopSyncing'); });
     },
 
-    setElementVisible_: function(element, visible) {
-      element.hidden = !visible;
-      if (visible)
-        element.classList.remove('hidden');
-      else
-        element.classList.add('hidden');
-    },
-
     setSyncEnabled_: function(enabled) {
       this.syncEnabled = enabled;
     },
 
     setSyncSetupCompleted_: function(completed) {
       this.syncSetupCompleted = completed;
-      this.setElementVisible_($('customize-sync'), completed);
+      $('customize-sync').hidden = !completed;
       $('privacy-dashboard-link').hidden = !completed;
     },
 
     setAccountPicture_: function(image) {
       $('account-picture').src = image;
     },
 
     setSyncStatus_: function(status) {
       var statusSet = status != '';
       $('sync-overview').hidden = statusSet;
       $('sync-status').hidden = !statusSet;
       $('sync-status-text').innerHTML = status;
     },
 
     setSyncStatusErrorVisible_: function(visible) {
       visible ? $('sync-status').classList.add('sync-error') :
                 $('sync-status').classList.remove('sync-error');
     },
 
     setSyncActionLinkEnabled_: function(enabled) {
       $('sync-action-link').disabled = !enabled;
     },
 
     setSyncActionLinkLabel_: function(status) {
       $('sync-action-link').textContent = status;
 
       // link-button does is not zero-area when the contents of the button are
       // empty, so explicitly hide the element.
-      this.setElementVisible_($('sync-action-link'), status.length != 0);
+      $('sync-action-link').hidden = !status.length;
     },
 
     setProfilesSectionVisible_: function(visible) {
-      this.setElementVisible_($('profiles-create'), visible);
+      $('profiles-create').hidden = !visible;
     },
 
     setNewProfileButtonEnabled_: function(enabled) {
       $('new-profile').disabled = !enabled;
       if (enabled)
         $('profiles-create').classList.remove('disabled');
       else
         $('profiles-create').classList.add('disabled');
     },
 
     setStartStopButtonVisible_: function(visible) {
-      this.setElementVisible_($('start-stop-sync'), visible);
+      $('start-stop-sync').hidden = !visible;
     },
 
     setStartStopButtonEnabled_: function(enabled) {
       $('start-stop-sync').disabled = !enabled;
     },
 
     setStartStopButtonLabel_: function(label) {
       $('start-stop-sync').textContent = label;
     },
 
     setGtkThemeButtonEnabled_: function(enabled) {
       if (!cr.isChromeOS && navigator.platform.match(/linux|BSD/i)) {
         $('themes-GTK-button').disabled = !enabled;
       }
     },
 
     setThemesResetButtonEnabled_: function(enabled) {
       $('themes-reset').disabled = !enabled;
     },
 
     hideSyncSection_: function() {
-      this.setElementVisible_($('sync-section'), false);
+      $('sync-section').hidden = true;
     },
 
     /**
      * Toggles the visibility of the data type checkboxes based on whether they
      * are enabled on not.
      * @param {Object} dict A mapping from data type to a boolean indicating
      *     whether it is enabled.
      * @private
      */
     setRegisteredDataTypes_: function(dict) {
@@ skipping 48 matching lines @@
       PersonalOptions.getInstance()[name + '_'](value);
     };
   });
 
   // Export
   return {
     PersonalOptions: PersonalOptions
   };
 
 });