Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: chrome/browser/resources/options/options_page.js

Issue 7067036: Options: Remove the hidden class, since we override the hidden attribute to set (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 ///////////////////////////////////////////////////////////////////////////// 6 /////////////////////////////////////////////////////////////////////////////
7 // OptionsPage class: 7 // OptionsPage class:
8 8
9 /** 9 /**
10 * Base class for options page. 10 * Base class for options page.
(...skipping 830 matching lines...) Expand 10 before | Expand all | Expand 10 after
841 841
842 /** 842 /**
843 * Sets page visibility. 843 * Sets page visibility.
844 */ 844 */
845 set visible(visible) { 845 set visible(visible) {
846 if ((this.visible && visible) || (!this.visible && !visible)) 846 if ((this.visible && visible) || (!this.visible && !visible))
847 return; 847 return;
848 848
849 this.setContainerVisibility_(visible); 849 this.setContainerVisibility_(visible);
850 if (visible) { 850 if (visible) {
851 this.pageDiv.classList.remove('hidden'); 851 this.pageDiv.hidden = false;
852 852
853 if (this.tab) 853 if (this.tab)
854 this.tab.classList.add('navbar-item-selected'); 854 this.tab.classList.add('navbar-item-selected');
855 } else { 855 } else {
856 this.pageDiv.classList.add('hidden'); 856 this.pageDiv.hidden = true;
857 857
858 if (this.tab) 858 if (this.tab)
859 this.tab.classList.remove('navbar-item-selected'); 859 this.tab.classList.remove('navbar-item-selected');
860 } 860 }
861 861
862 OptionsPage.updatePageFreezeStates(); 862 OptionsPage.updatePageFreezeStates();
863 863
864 // A subpage was shown or hidden. 864 // A subpage was shown or hidden.
865 if (!this.isOverlay && this.nestingLevel > 0) { 865 if (!this.isOverlay && this.nestingLevel > 0) {
866 OptionsPage.updateSubpageBackdrop_(); 866 OptionsPage.updateSubpageBackdrop_();
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
998 shouldClose: function() { 998 shouldClose: function() {
999 return true; 999 return true;
1000 }, 1000 },
1001 }; 1001 };
1002 1002
1003 // Export 1003 // Export
1004 return { 1004 return {
1005 OptionsPage: OptionsPage 1005 OptionsPage: OptionsPage
1006 }; 1006 };
1007 }); 1007 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698