kWebGraphicsContext3DPerferredGLExtensions -> kWebGLPreferredGLExtensions

content/renderer/webgraphicscontext3d_command_buffer_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if defined(ENABLE_GPU)
 
 #include "content/renderer/webgraphicscontext3d_command_buffer_impl.h"
 
 #include <GLES2/gl2.h>
 #ifndef GL_GLEXT_PROTOTYPES
@@ skipping 29 matching lines @@
       cached_width_(0),
       cached_height_(0),
       bound_fbo_(0) {
 }
 
 WebGraphicsContext3DCommandBufferImpl::
     ~WebGraphicsContext3DCommandBufferImpl() {
   delete context_;
 }
 
-static const char* kWebGraphicsContext3DPerferredGLExtensions =
+// This string should only be passed for WebGL contexts. Nothing ELSE!!!
+// Compositor contexts, Canvas2D contexts, Pepper Contexts, nor any other use of
+// a context should not pass this string.
+static const char* kWebGLPreferredGLExtensions =
     "GL_OES_packed_depth_stencil "
     "GL_OES_depth24 "
     "GL_CHROMIUM_webglsl";
 
 bool WebGraphicsContext3DCommandBufferImpl::initialize(
     WebGraphicsContext3D::Attributes attributes,
     WebKit::WebView* web_view,
     bool render_directly_to_web_view) {
   TRACE_EVENT0("gpu", "WebGfxCtx3DCmdBfrImpl::initialize");
   webkit_glue::BindSkiaToCommandBufferGL();
@@ skipping 40 matching lines @@
   if (render_directly_to_web_view) {
     RenderView* renderview = RenderView::FromWebView(web_view);
     if (!renderview)
       return false;
 
     web_view_ = web_view;
     context_ = RendererGLContext::CreateViewContext(
         host,
         renderview->compositing_surface(),
         renderview->routing_id(),
-        kWebGraphicsContext3DPerferredGLExtensions,
+        kWebGLPreferredGLExtensions,

[jamesr, 2011/05/24 22:05:11]

i think this codepath (render_directly_to_web_view) is only used for compositor
contexts, so this seems to contradict the comment above. should we be passing a
different string in?

         attribs,
         active_url);
     if (context_) {
       context_->SetSwapBuffersCallback(
           NewCallback(this,
               &WebGraphicsContext3DCommandBufferImpl::OnSwapBuffersComplete));
     }
   } else {
     bool compositing_enabled = !CommandLine::ForCurrentProcess()->HasSwitch(
         switches::kDisableAcceleratedCompositing);
     RendererGLContext* parent_context = NULL;
     // If GPU compositing is enabled we need to create a GL context that shares
     // resources with the compositor's context.
     if (compositing_enabled) {
       // Asking for the WebGraphicsContext3D on the WebView will force one to
       // be created if it doesn't already exist. When the compositor is created
       // for the view it will use the same context.
       WebKit::WebGraphicsContext3D* view_context =
           web_view->graphicsContext3D();
       if (view_context) {
         WebGraphicsContext3DCommandBufferImpl* context_impl =
             static_cast<WebGraphicsContext3DCommandBufferImpl*>(view_context);
         parent_context = context_impl->context_;
       }
     }
     context_ = RendererGLContext::CreateOffscreenContext(
         host,
         parent_context,
         gfx::Size(1, 1),
-        kWebGraphicsContext3DPerferredGLExtensions,
+        kWebGLPreferredGLExtensions,

[jamesr, 2011/05/24 22:05:11]

this is used for webgl, canvas 2d, and probably other stuff too :(

         attribs,
         active_url);
     web_view_ = NULL;
   }
   if (!context_)
     return false;
 
   gl_ = context_->GetImplementation();
   context_->SetContextLostCallback(
       NewCallback(this,
@@ skipping 886 matching lines @@
     context_lost_callback_->onContextLost();
   }
 
   RenderView* renderview =
       web_view_ ? RenderView::FromWebView(web_view_) : NULL;
   if (renderview)
     renderview->OnViewContextSwapBuffersAborted();
 }
 
 #endif  // defined(ENABLE_GPU)