Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 7067033: Add pyauto commands to access local state. (Closed)

Created:
9 years, 7 months ago by Miranda Callahan
Modified:
9 years, 7 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, Nirnimesh, John Grabowski, kkania, anantha, dyu1, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add pyauto commands to access local state. BUG=83766 TEST=forthcoming Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86494

Patch Set 1 #

Total comments: 8

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -1 line) Patch
M chrome/browser/automation/testing_automation_provider.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 chunks +46 lines, -0 lines 0 comments Download
M chrome/test/pyautolib/prefs_info.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Miranda Callahan
9 years, 7 months ago (2011-05-24 19:06:17 UTC) #1
Nirnimesh
Just some minor comments. http://codereview.chromium.org/7067033/diff/1/chrome/test/pyautolib/prefs_info.py File chrome/test/pyautolib/prefs_info.py (right): http://codereview.chromium.org/7067033/diff/1/chrome/test/pyautolib/prefs_info.py#newcode9 chrome/test/pyautolib/prefs_info.py:9: Obtain one of these from ...
9 years, 7 months ago (2011-05-24 19:49:02 UTC) #2
Miranda Callahan
Thanks, Nirnimesh -- also changed the method names in TestingAutomationProvider to match GetLocalStatePrefsInfo. http://codereview.chromium.org/7067033/diff/1/chrome/test/pyautolib/prefs_info.py File ...
9 years, 7 months ago (2011-05-24 20:42:33 UTC) #3
Nirnimesh
9 years, 7 months ago (2011-05-24 21:25:37 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698