ui/base/models/menu_model.h - Issue 7067032: Add MenuModelAdapter to wrap ui::MenuModel with views::MenuDelegate interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/models/menu_model.h

Issue 7067032: Add MenuModelAdapter to wrap ui::MenuModel with views::MenuDelegate interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implemented reviewer recommendations. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/models/menu_model.h

diff --git a/ui/base/models/menu_model.h b/ui/base/models/menu_model.h

index daca3dae2c6395e1cd123e511d0a69771e9438aa..a0c3627167fc5eb15f6f0716eaad9a1b5dbda206 100644

--- a/ui/base/models/menu_model.h

+++ b/ui/base/models/menu_model.h

@@ -44,7 +44,8 @@ class MenuModel {

// Returns the index of the first item. This is 0 for most menus except the

// system menu on Windows. |native_menu| is the menu to locate the start index

- // within. It is guaranteed to be reset to a clean default state.

+ // within. It is guaranteed to be reset to a clean default state. Some

+ // callers of this method may pass NULL for native_menu.

// IMPORTANT: If the model implementation returns something _other_ than 0

// here, it must offset the values for |index| it passes to the

// methods below by this number - this is NOT done automatically!

« no previous file with comments | « chrome/browser/ui/views/chrome_views_delegate.cc ('k') | ui/base/models/menu_model.cc » ('j') | no next file with comments »