Issue 7067030: Change network connecting animation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7067030: Change network connecting animation (Closed)

Created:
9 years, 7 months ago by DaveMoore

Modified:
9 years, 7 months ago

Reviewers:
Charlie Lee, zel

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Change network connecting animation BUG=chromium-os:15687 TEST=Disable / reenable wifi and check animation Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86630

Patch Set 2 : Cleanup #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -26 lines)			Patch
M	chrome/browser/chromeos/status/network_dropdown_button.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu.cc	View		3 chunks	+26 lines, -21 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu_button.cc	View	1	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Charlie Lee

LGTM with one issue. http://codereview.chromium.org/7067030/diff/1006/chrome/browser/chromeos/status/network_menu_button.cc File chrome/browser/chromeos/status/network_menu_button.cc (right): http://codereview.chromium.org/7067030/diff/1006/chrome/browser/chromeos/status/network_menu_button.cc#newcode107 chrome/browser/chromeos/status/network_menu_button.cc:107: const int NetworkMenuButton::kThrobDuration = 1000; ...

9 years, 7 months ago (2011-05-24 19:32:38 UTC) #2

LGTM

approved for merge into 742

Expand Messages | Collapse Messages

Issue 7067030: Change network connecting animation (Closed)

Description

Patch Set 1 #

Patch Set 2 : Cleanup #

Messages