chrome/browser/resources/file_manager/js/file_manager.js - Issue 7067020: Moving mediaplayer to the chrome filebrowser. Observable behaviour should not change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/file_manager/js/file_manager.js

Issue 7067020: Moving mediaplayer to the chrome filebrowser. Observable behaviour should not change. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Resolved conflicts. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/component_extension_resources.grd ('k') | chrome/browser/resources/file_manager/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/file_manager/js/file_manager.js

diff --git a/chrome/browser/resources/file_manager/js/file_manager.js b/chrome/browser/resources/file_manager/js/file_manager.js

index 0f83227757ec665b4a53b04a250a325fbf2d5e02..4ecc60e594ca8096e84a4805dc9102edcd289dbd 100644

--- a/chrome/browser/resources/file_manager/js/file_manager.js

+++ b/chrome/browser/resources/file_manager/js/file_manager.js

@@ -1622,8 +1622,11 @@ FileManager.prototype = {

return;

}

- var i = this.currentList_.selectionModel.leadIndex;

- var entry = this.dataModel_.item(i);

+ var entry = this.selection.leadEntry;

+ if (!entry) {

+ console.log('Invalid selection');

+ return;

+ }

if (entry.isDirectory)

return this.changeDirectory(entry.fullPath);

« no previous file with comments | « chrome/browser/resources/component_extension_resources.grd ('k') | chrome/browser/resources/file_manager/manifest.json » ('j') | no next file with comments »