Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: src/ia32/macro-assembler-ia32.cc

Issue 7067018: Fix polarity of CheckMap smi check on ia32 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 void MacroAssembler::CmpInstanceType(Register map, InstanceType type) { 276 void MacroAssembler::CmpInstanceType(Register map, InstanceType type) {
277 cmpb(FieldOperand(map, Map::kInstanceTypeOffset), 277 cmpb(FieldOperand(map, Map::kInstanceTypeOffset),
278 static_cast<int8_t>(type)); 278 static_cast<int8_t>(type));
279 } 279 }
280 280
281 281
282 void MacroAssembler::CheckMap(Register obj, 282 void MacroAssembler::CheckMap(Register obj,
283 Handle<Map> map, 283 Handle<Map> map,
284 Label* fail, 284 Label* fail,
285 SmiCheckType smi_check_type) { 285 SmiCheckType smi_check_type) {
286 if (smi_check_type == DONT_DO_SMI_CHECK) { 286 if (smi_check_type == DO_SMI_CHECK) {
287 JumpIfSmi(obj, fail); 287 JumpIfSmi(obj, fail);
288 } 288 }
289 cmp(FieldOperand(obj, HeapObject::kMapOffset), Immediate(map)); 289 cmp(FieldOperand(obj, HeapObject::kMapOffset), Immediate(map));
290 j(not_equal, fail); 290 j(not_equal, fail);
291 } 291 }
292 292
293 293
294 void MacroAssembler::DispatchMap(Register obj, 294 void MacroAssembler::DispatchMap(Register obj,
295 Handle<Map> map, 295 Handle<Map> map,
296 Handle<Code> success, 296 Handle<Code> success,
(...skipping 1802 matching lines...) Expand 10 before | Expand all | Expand 10 after
2099 2099
2100 // Check that the code was patched as expected. 2100 // Check that the code was patched as expected.
2101 ASSERT(masm_.pc_ == address_ + size_); 2101 ASSERT(masm_.pc_ == address_ + size_);
2102 ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap); 2102 ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap);
2103 } 2103 }
2104 2104
2105 2105
2106 } } // namespace v8::internal 2106 } } // namespace v8::internal
2107 2107
2108 #endif // V8_TARGET_ARCH_IA32 2108 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698