An edit for SetText needs to be merged with previous edit for omnibox.

views/controls/textfield/textfield_views_model_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/auto_reset.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/clipboard/clipboard.h"
@@ skipping 255 matching lines @@
   EXPECT_EQ(0U, fragments[0].range.start());
   EXPECT_EQ(11U, fragments[0].range.end());
 }
 
 TEST_F(TextfieldViewsModelTest, SetText) {
   TextfieldViewsModel model(NULL);
   model.Append(ASCIIToUTF16("HELLO"));
   model.MoveCursorToEnd(false);
   model.SetText(ASCIIToUTF16("GOODBYE"));
   EXPECT_STR_EQ("GOODBYE", model.text());
-  EXPECT_EQ(0U, model.cursor_pos());
+  // SetText won't reset the cursor posistion.
+  EXPECT_EQ(5U, model.cursor_pos());
   model.SelectAll();
   EXPECT_STR_EQ("GOODBYE", model.GetSelectedText());
   model.MoveCursorToEnd(false);
   EXPECT_EQ(7U, model.cursor_pos());
 
   model.SetText(ASCIIToUTF16("BYE"));
-  EXPECT_EQ(0U, model.cursor_pos());
+  // Setting shorter string moves the cursor to the end of the new string.
+  EXPECT_EQ(3U, model.cursor_pos());
   EXPECT_EQ(string16(), model.GetSelectedText());
   model.SetText(ASCIIToUTF16(""));
   EXPECT_EQ(0U, model.cursor_pos());
 }
 
 TEST_F(TextfieldViewsModelTest, Clipboard) {
   ui::Clipboard* clipboard
       = views::ViewsDelegate::views_delegate->GetClipboard();
   string16 initial_clipboard_text;
   clipboard->ReadText(ui::Clipboard::BUFFER_STANDARD, &initial_clipboard_text);
@@ skipping 382 matching lines @@
   EXPECT_STR_EQ("", model.text());
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("a", model.text());
 
   // Continuous inserts are treated as one edit.
   model.InsertChar('b');
   model.InsertChar('c');
   EXPECT_STR_EQ("abc", model.text());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("a", model.text());
+  EXPECT_EQ(1U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("", model.text());
+  EXPECT_EQ(0U, model.cursor_pos());
 
   // Undoing further shouldn't change the text.
   EXPECT_FALSE(model.Undo());
   EXPECT_STR_EQ("", model.text());
   EXPECT_FALSE(model.Undo());
   EXPECT_STR_EQ("", model.text());
+  EXPECT_EQ(0U, model.cursor_pos());
 
   // Redoing to the latest text.
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("a", model.text());
+  EXPECT_EQ(1U, model.cursor_pos());
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("abc", model.text());
+  EXPECT_EQ(3U, model.cursor_pos());
 
   // Backspace ===============================
   EXPECT_TRUE(model.Backspace());
   EXPECT_STR_EQ("ab", model.text());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("abc", model.text());
+  EXPECT_EQ(3U, model.cursor_pos());
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("ab", model.text());
+  EXPECT_EQ(2U, model.cursor_pos());
   // Continous backspaces are treated as one edit.
   EXPECT_TRUE(model.Backspace());
   EXPECT_TRUE(model.Backspace());
   EXPECT_STR_EQ("", model.text());
   // Extra backspace shouldn't affect the history.
   EXPECT_FALSE(model.Backspace());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("ab", model.text());
+  EXPECT_EQ(2U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("abc", model.text());
+  EXPECT_EQ(3U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("a", model.text());
+  EXPECT_EQ(1U, model.cursor_pos());
 
   // Clear history
   model.ClearEditHistory();
   EXPECT_FALSE(model.Undo());
   EXPECT_FALSE(model.Redo());
   EXPECT_STR_EQ("a", model.text());
+  EXPECT_EQ(1U, model.cursor_pos());
 
   // Delete ===============================
   model.SetText(ASCIIToUTF16("ABCDE"));
   model.ClearEditHistory();
   model.MoveCursorTo(2, false);
   EXPECT_TRUE(model.Delete());
   EXPECT_STR_EQ("ABDE", model.text());
   model.MoveCursorToHome(false);
   EXPECT_TRUE(model.Delete());
   EXPECT_STR_EQ("BDE", model.text());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("ABDE", model.text());
+  EXPECT_EQ(0U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("ABCDE", model.text());
+  EXPECT_EQ(2U, model.cursor_pos());
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("ABDE", model.text());
+  EXPECT_EQ(2U, model.cursor_pos());
   // Continous deletes are treated as one edit.
   EXPECT_TRUE(model.Delete());
   EXPECT_TRUE(model.Delete());
   EXPECT_STR_EQ("AB", model.text());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("ABDE", model.text());
+  EXPECT_EQ(2U, model.cursor_pos());
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("AB", model.text());
+  EXPECT_EQ(2U, model.cursor_pos());
+}
+
+TEST_F(TextfieldViewsModelTest, UndoRedo_SetText) {

[msw, 2011/06/02 10:16:42]

nit: perhaps comment that this is meant to simulate omnibox autosuggest use of
the textfield.

[oshima, 2011/06/02 19:11:42]

Done.

+  TextfieldViewsModel model(NULL);
+  model.InsertChar('w');
+  EXPECT_STR_EQ("w", model.text());
+  EXPECT_EQ(1U, model.cursor_pos());
+  model.SetText(ASCIIToUTF16("www.google.com"));
+  EXPECT_EQ(1U, model.cursor_pos());
+  EXPECT_STR_EQ("www.google.com", model.text());
+  model.SelectRange(ui::Range(14, 1));
+  model.InsertChar('w');
+  EXPECT_STR_EQ("ww", model.text());
+  model.SetText(ASCIIToUTF16("www.google.com"));
+  model.SelectRange(ui::Range(14, 2));
+  model.InsertChar('w');
+  EXPECT_STR_EQ("www", model.text());
+  model.SetText(ASCIIToUTF16("www.google.com"));
+  model.SelectRange(ui::Range(14, 3));
+  model.InsertChar('.');
+  EXPECT_STR_EQ("www.", model.text());
+  model.SetText(ASCIIToUTF16("www.google.com"));
+  model.SelectRange(ui::Range(14, 4));
+  model.InsertChar('y');
+  EXPECT_STR_EQ("www.y", model.text());
+  model.SetText(ASCIIToUTF16("www.youtube.com"));
+  EXPECT_STR_EQ("www.youtube.com", model.text());
+  EXPECT_EQ(5U, model.cursor_pos());
+
+  EXPECT_TRUE(model.Undo());
+  EXPECT_STR_EQ("www.google.com", model.text());
+  EXPECT_EQ(4U, model.cursor_pos());
+  EXPECT_TRUE(model.Undo());
+  EXPECT_STR_EQ("www.google.com", model.text());
+  EXPECT_EQ(3U, model.cursor_pos());
+  EXPECT_TRUE(model.Undo());
+  EXPECT_STR_EQ("www.google.com", model.text());
+  EXPECT_EQ(2U, model.cursor_pos());
+  EXPECT_TRUE(model.Undo());
+  EXPECT_STR_EQ("www.google.com", model.text());
+  EXPECT_EQ(1U, model.cursor_pos());
+  EXPECT_TRUE(model.Undo());
+  EXPECT_STR_EQ("", model.text());
+  EXPECT_EQ(0U, model.cursor_pos());
+  EXPECT_FALSE(model.Undo());
+  EXPECT_TRUE(model.Redo());
+  EXPECT_STR_EQ("www.google.com", model.text());
+  EXPECT_EQ(1U, model.cursor_pos());
+  EXPECT_TRUE(model.Redo());
+  EXPECT_STR_EQ("www.google.com", model.text());
+  EXPECT_EQ(2U, model.cursor_pos());
+  EXPECT_TRUE(model.Redo());
+  EXPECT_STR_EQ("www.google.com", model.text());
+  EXPECT_EQ(3U, model.cursor_pos());
+  EXPECT_TRUE(model.Redo());
+  EXPECT_STR_EQ("www.google.com", model.text());
+  EXPECT_EQ(4U, model.cursor_pos());
+  EXPECT_TRUE(model.Redo());
+  EXPECT_STR_EQ("www.youtube.com", model.text());
+  EXPECT_EQ(5U, model.cursor_pos());
+  EXPECT_FALSE(model.Redo());
 }
 
 TEST_F(TextfieldViewsModelTest, UndoRedo_CutCopyPasteTest) {
   TextfieldViewsModel model(NULL);
   model.SetText(ASCIIToUTF16("ABCDE"));
   EXPECT_FALSE(model.Redo());  // nothing to redo
   // Cut
   model.MoveCursorTo(1, false);
   model.MoveCursorTo(3, true);
   model.Cut();
   EXPECT_STR_EQ("ADE", model.text());
+  EXPECT_EQ(1U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("ABCDE", model.text());
+  EXPECT_EQ(3U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("", model.text());
+  EXPECT_EQ(0U, model.cursor_pos());
   EXPECT_FALSE(model.Undo());  // no more undo
   EXPECT_STR_EQ("", model.text());
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("ABCDE", model.text());
+  EXPECT_EQ(0U, model.cursor_pos());
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("ADE", model.text());
+  EXPECT_EQ(1U, model.cursor_pos());
   EXPECT_FALSE(model.Redo());  // no more redo
   EXPECT_STR_EQ("ADE", model.text());
 
   model.Paste();
   model.Paste();
   model.Paste();
   EXPECT_STR_EQ("ABCBCBCDE", model.text());
+  EXPECT_EQ(7U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("ABCBCDE", model.text());
+  EXPECT_EQ(5U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("ABCDE", model.text());
+  EXPECT_EQ(3U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("ADE", model.text());
+  EXPECT_EQ(1U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("ABCDE", model.text());
+  EXPECT_EQ(3U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("", model.text());
+  EXPECT_EQ(0U, model.cursor_pos());
   EXPECT_FALSE(model.Undo());
   EXPECT_STR_EQ("", model.text());
   EXPECT_TRUE(model.Redo());
-  EXPECT_STR_EQ("ABCDE", model.text());
+  EXPECT_STR_EQ("ABCDE", model.text());  // Redoing SetText
+  EXPECT_EQ(0U, model.cursor_pos());
+
   // Redo
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("ADE", model.text());
+  EXPECT_EQ(1U, model.cursor_pos());
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("ABCDE", model.text());
+  EXPECT_EQ(3U, model.cursor_pos());
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("ABCBCDE", model.text());
+  EXPECT_EQ(5U, model.cursor_pos());
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("ABCBCBCDE", model.text());
+  EXPECT_EQ(7U, model.cursor_pos());
   EXPECT_FALSE(model.Redo());
 
   // with SelectRange
   model.SelectRange(ui::Range(1, 3));
   EXPECT_TRUE(model.Cut());
   EXPECT_STR_EQ("ABCBCDE", model.text());
+  EXPECT_EQ(1U, model.cursor_pos());
   model.SelectRange(ui::Range(1, 1));
   EXPECT_FALSE(model.Cut());
   model.MoveCursorToEnd(false);
   EXPECT_TRUE(model.Paste());
   EXPECT_STR_EQ("ABCBCDEBC", model.text());
+  EXPECT_EQ(9U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("ABCBCDE", model.text());
+  EXPECT_EQ(7U, model.cursor_pos());
   // empty cut shouldn't create an edit.
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("ABCBCBCDE", model.text());
+  EXPECT_EQ(3U, model.cursor_pos());
 
   // Copy
   ResetModel(&model);
   model.SetText(ASCIIToUTF16("12345"));
   EXPECT_STR_EQ("12345", model.text());
+  EXPECT_EQ(0U, model.cursor_pos());
   model.MoveCursorTo(1, false);
   model.MoveCursorTo(3, true);
-  model.Copy();
+  model.Copy();  // Copy "23"
   EXPECT_STR_EQ("12345", model.text());
-  model.Paste();
+  EXPECT_EQ(3U, model.cursor_pos());
+  model.Paste();  // Paste "23" into "23".
   EXPECT_STR_EQ("12345", model.text());
+  EXPECT_EQ(3U, model.cursor_pos());
   model.Paste();
   EXPECT_STR_EQ("1232345", model.text());
+  EXPECT_EQ(5U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("12345", model.text());
-  EXPECT_FALSE(model.Undo());  // no text change
+  EXPECT_EQ(3U, model.cursor_pos());
+  // TODO(oshima): We need to change the return type from bool to enum.
+  EXPECT_FALSE(model.Undo());  // No text change.
   EXPECT_STR_EQ("12345", model.text());
+  EXPECT_EQ(3U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("", model.text());
   EXPECT_FALSE(model.Undo());
   // Redo
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("12345", model.text());
-  EXPECT_FALSE(model.Redo());  // no text change.
-  EXPECT_STR_EQ("12345", model.text());
+  EXPECT_EQ(0U, model.cursor_pos());
+  EXPECT_TRUE(model.Redo());
+  EXPECT_STR_EQ("12345", model.text());  // For 1st paste
+  EXPECT_EQ(3U, model.cursor_pos());
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("1232345", model.text());
+  EXPECT_EQ(5U, model.cursor_pos());
   EXPECT_FALSE(model.Redo());
   EXPECT_STR_EQ("1232345", model.text());
 
   // with SelectRange
   model.SelectRange(ui::Range(1, 3));
   model.Copy();
   EXPECT_STR_EQ("1232345", model.text());
   model.MoveCursorToEnd(false);
   EXPECT_TRUE(model.Paste());
   EXPECT_STR_EQ("123234523", model.text());
+  EXPECT_EQ(9U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("1232345", model.text());
+  EXPECT_EQ(7U, model.cursor_pos());
 }
 
 TEST_F(TextfieldViewsModelTest, UndoRedo_CursorTest) {
   TextfieldViewsModel model(NULL);
   model.InsertChar('a');
   model.MoveCursorLeft(false);
   model.MoveCursorRight(false);
   model.InsertChar('b');
   // Moving cursor shoudln't create a new edit.
   EXPECT_STR_EQ("ab", model.text());
   EXPECT_FALSE(model.Redo());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("", model.text());
   EXPECT_FALSE(model.Undo());
   EXPECT_STR_EQ("", model.text());
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("ab", model.text());
+  EXPECT_EQ(2U, model.cursor_pos());
   EXPECT_FALSE(model.Redo());
 }
 
 void RunInsertReplaceTest(TextfieldViewsModel& model) {
+  ui::Range r;
+  model.GetSelectedRange(&r);
+  bool reverse = r.is_reversed();
+
   model.InsertChar('1');
   model.InsertChar('2');
   model.InsertChar('3');
   EXPECT_STR_EQ("a123d", model.text());
+  EXPECT_EQ(4U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("abcd", model.text());
+  EXPECT_EQ(reverse ? 1U : 3U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("", model.text());
+  EXPECT_EQ(0U, model.cursor_pos());
   EXPECT_FALSE(model.Undo());
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("abcd", model.text());
+  EXPECT_EQ(0U, model.cursor_pos());  // By SetText
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("a123d", model.text());
+  EXPECT_EQ(4U, model.cursor_pos());
   EXPECT_FALSE(model.Redo());
 }
 
 void RunOverwriteReplaceTest(TextfieldViewsModel& model) {
+  ui::Range r;
+  model.GetSelectedRange(&r);
+  bool reverse = r.is_reversed();
+
   model.ReplaceChar('1');
   model.ReplaceChar('2');
   model.ReplaceChar('3');
   model.ReplaceChar('4');
   EXPECT_STR_EQ("a1234", model.text());
+  EXPECT_EQ(5U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("abcd", model.text());
+  EXPECT_EQ(reverse ? 1U : 3U, model.cursor_pos());
   EXPECT_TRUE(model.Undo());
   EXPECT_STR_EQ("", model.text());
+  EXPECT_EQ(0U, model.cursor_pos());
   EXPECT_FALSE(model.Undo());
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("abcd", model.text());
+  EXPECT_EQ(0U, model.cursor_pos());
   EXPECT_TRUE(model.Redo());
   EXPECT_STR_EQ("a1234", model.text());
+  EXPECT_EQ(5U, model.cursor_pos());
   EXPECT_FALSE(model.Redo());
 }
 
 TEST_F(TextfieldViewsModelTest, UndoRedo_ReplaceTest) {
   // By Cursor
   {
     SCOPED_TRACE("forward & insert by cursor");
     TextfieldViewsModel model(NULL);
     model.SetText(ASCIIToUTF16("abcd"));
     model.MoveCursorTo(1, false);
@@ skipping 336 matching lines @@
   model.ApplyTextStyle(strike, invalid);
   model.GetFragments(&fragments);
   EXPECT_EQ(1U, fragments.size());
 
   EXPECT_EQ(0U, fragments[0].range.start());
   EXPECT_EQ(10U, fragments[0].range.end());
   EXPECT_EQ(black, fragments[0].style->foreground());
 }
 
 }  // namespace views