Don't re-enter when destroying FlashNetConnector

ppapi/proxy/ppb_flash_net_connector_proxy.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/ppb_flash_net_connector_proxy.h"
 
 #include <algorithm>
 
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/c/private/ppb_flash_net_connector.h"
 #include "ppapi/proxy/plugin_dispatcher.h"
 #include "ppapi/proxy/plugin_resource.h"
 #include "ppapi/proxy/ppapi_messages.h"
 #include "ppapi/proxy/serialized_var.h"
 
 namespace pp {
 namespace proxy {
 
 std::string NetAddressToString(const PP_Flash_NetAddress& addr) {
   return std::string(addr.data, std::min(static_cast<size_t>(addr.size),
                                          sizeof(addr.data)));
 }
 
 void StringToNetAddress(const std::string& str, PP_Flash_NetAddress* addr) {
   addr->size = std::min(str.size(), sizeof(addr->data));
   memcpy(addr->data, str.data(), addr->size);
 }
 
+class AbortCallbackTask : public Task {
+ public:
+  AbortCallbackTask(PP_CompletionCallback callback)
+      : callback_(callback) {}
+
+  virtual void Run() {
+    PP_RunCompletionCallback(&callback_, PP_ERROR_ABORTED);
+  }
+
+ private:
+  PP_CompletionCallback callback_;
+};
+
 class FlashNetConnector : public PluginResource {
  public:
   FlashNetConnector(const HostResource& resource)
       : PluginResource(resource),
         callback_(PP_BlockUntilComplete()),
         local_addr_out_(NULL),
         remote_addr_out_(NULL) {
   }
   ~FlashNetConnector() {
     if (callback_.func)
-      PP_RunCompletionCallback(&callback_, PP_ERROR_ABORTED);
+      MessageLoop::current()->PostTask(FROM_HERE,

[viettrungluu, 2011/05/24 17:39:48]

Nit: Our style rules apparently dictate braces for this |if|.

+                                       new AbortCallbackTask(callback_));
   }
 
   // Resource overrides.
   virtual FlashNetConnector* AsFlashNetConnector() {
     return this;
   }
 
   bool HasCallback() const {
     return callback_.func != NULL;
   }
@@ skipping 268 matching lines @@
   } else {
     dispatcher()->Send(new PpapiMsg_PPBFlashNetConnector_ConnectACK(
         INTERFACE_ID_PPB_FLASH_NETCONNECTOR,
         info->resource, result,
         IPC::InvalidPlatformFileForTransit(), std::string(), std::string()));
   }
 }
 
 }  // namespace proxy
 }  // namespace pp