Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 7067011: Update autofill test to take into account for new valdation change with phone/fax numbers. (Closed)

Created:
9 years, 7 months ago by dyu1
Modified:
9 years, 6 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, John Grabowski, anantha, Nirnimesh, dyu1, Paweł Hajdan Jr.
Visibility:
Public.

Description

Update autofill test to take into account for new valdation change with phone/fax numbers. - testAUtofillInvalid Phone/Fax information entered into the prefs UI is no longer validated or rejected. Update existing automation test. TEST=none BUG=83677 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86399

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chrome/test/functional/autofill.py View 1 1 chunk +10 lines, -5 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
dyu1
9 years, 7 months ago (2011-05-24 01:30:46 UTC) #1
Nirnimesh
http://codereview.chromium.org/7067011/diff/1/chrome/test/functional/autofill.py File chrome/test/functional/autofill.py (right): http://codereview.chromium.org/7067011/diff/1/chrome/test/functional/autofill.py#newcode99 chrome/test/functional/autofill.py:99: self.assertFalse([without_invalid], you want assertNotEqual()
9 years, 7 months ago (2011-05-24 02:39:43 UTC) #2
dyu1
http://codereview.chromium.org/7067011/diff/1/chrome/test/functional/autofill.py File chrome/test/functional/autofill.py (right): http://codereview.chromium.org/7067011/diff/1/chrome/test/functional/autofill.py#newcode99 chrome/test/functional/autofill.py:99: self.assertFalse([without_invalid], On 2011/05/24 02:39:43, Nirnimesh wrote: > you want ...
9 years, 7 months ago (2011-05-24 03:20:00 UTC) #3
Nirnimesh
LGTM http://codereview.chromium.org/7067011/diff/3/chrome/test/functional/autofill.py File chrome/test/functional/autofill.py (right): http://codereview.chromium.org/7067011/diff/3/chrome/test/functional/autofill.py#newcode100 chrome/test/functional/autofill.py:100: self.GetAutofillProfile()['profiles'], fix indentation
9 years, 7 months ago (2011-05-24 05:32:41 UTC) #4
dyu1
9 years, 6 months ago (2011-06-07 03:25:44 UTC) #5
http://codereview.chromium.org/7067011/diff/3/chrome/test/functional/autofill.py
File chrome/test/functional/autofill.py (right):

http://codereview.chromium.org/7067011/diff/3/chrome/test/functional/autofill...
chrome/test/functional/autofill.py:100: self.GetAutofillProfile()['profiles'],
On 2011/05/24 05:32:41, Nirnimesh wrote:
> fix indentation

Done.

Powered by Google App Engine
This is Rietveld 408576698