Issue 7067007: Remove prefix eliding

Issue 7067007: Remove prefix eliding (Closed)

Created:
9 years, 7 months ago by sail

Modified:
9 years, 7 months ago

Reviewers:
MAD, Peter Kasting

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove prefix eliding For M12 we experimented with eliding common prefixes in tab titles. After lots of feedback we've decided to remove this feature. BUG=83668 TEST=Testing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86371

Patch Set 1 #

Total comments: 2

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -481 lines)			Patch
M	chrome/browser/ui/cocoa/tabs/tab_controller.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_controller.mm	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm	View	7 chunks	+0 lines, -44 lines	0 comments	Download
D	chrome/browser/ui/title_prefix_matcher.h	View	1 chunk	+0 lines, -56 lines	0 comments	Download
D	chrome/browser/ui/title_prefix_matcher.cc	View	1 chunk	+0 lines, -117 lines	0 comments	Download
D	chrome/browser/ui/title_prefix_matcher_unittest.cc	View	1 chunk	+0 lines, -175 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/base_tab.cc	View	3 chunks	+1 line, -17 lines	2 comments	Download
M	chrome/browser/ui/views/tabs/base_tab_strip.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/base_tab_strip.cc	View	4 chunks	+0 lines, -33 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/side_tab_strip.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/side_tab_strip.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_renderer_data.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_renderer_data.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

LGTM http://codereview.chromium.org/7067007/diff/1/chrome/browser/ui/views/tabs/base_tab.cc File chrome/browser/ui/views/tabs/base_tab.cc (right): http://codereview.chromium.org/7067007/diff/1/chrome/browser/ui/views/tabs/base_tab.cc#newcode487 chrome/browser/ui/views/tabs/base_tab.cc:487: canvas->AsCanvasSkia()->DrawFadeTruncatingString(title, Nit: I think we should also simplify ...

9 years, 7 months ago (2011-05-23 23:06:42 UTC) #2

sail

9 years, 7 months ago (2011-05-23 23:25:35 UTC) #3

http://codereview.chromium.org/7067007/diff/1/chrome/browser/ui/views/tabs/ba...
File chrome/browser/ui/views/tabs/base_tab.cc (right):

http://codereview.chromium.org/7067007/diff/1/chrome/browser/ui/views/tabs/ba...
chrome/browser/ui/views/tabs/base_tab.cc:487:
canvas->AsCanvasSkia()->DrawFadeTruncatingString(title,
On 2011/05/23 23:06:43, Peter Kasting wrote:
> Nit: I think we should also simplify this API.  Let's remove the Head and
> HeadAndTail functionality entirely.

Sounds good. I'll send that out separately. I'm trying to get a minimal change
that Jason can approve for M12.

Expand Messages | Collapse Messages