Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 7066071: Removing defunct OpenMAX code. (Closed)

Created:
9 years, 6 months ago by scherkus (not reviewing)
Modified:
9 years, 5 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., jam, joi+watch-content_chromium.org, acolwell+watch_chromium.org, annacc, pam+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), darin-cc_chromium.org, scherkus (not reviewing)
Visibility:
Public.

Description

Removing defunct OpenMAX code. All of this code hasn't been used in over a year and has been replaced by VideoDecodeAccelerator and it's corresponding OpenMAX implementation OmxVideoDecodeAccelerator. BUG=none TEST=the world still compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87790

Patch Set 1 #

Patch Set 2 : removed tab #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4619 lines) Patch
M content/browser/renderer_host/browser_render_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_process_impl.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M media/base/media_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/media_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
D media/filters/omx_video_decoder.h View 1 chunk +0 lines, -82 lines 0 comments Download
D media/filters/omx_video_decoder.cc View 1 chunk +0 lines, -250 lines 0 comments Download
M media/media.gyp View 1 5 chunks +2 lines, -98 lines 0 comments Download
D media/omx/mock_omx.h View 1 chunk +0 lines, -101 lines 0 comments Download
D media/omx/mock_omx.cc View 1 chunk +0 lines, -159 lines 0 comments Download
D media/omx/omx_codec_unittest.cc View 1 chunk +0 lines, -483 lines 0 comments Download
D media/omx/omx_configurator.h View 1 chunk +0 lines, -154 lines 0 comments Download
D media/omx/omx_configurator.cc View 1 chunk +0 lines, -168 lines 0 comments Download
D media/omx/omx_unittest.cc View 1 chunk +0 lines, -421 lines 0 comments Download
D media/omx/run_all_unittests.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D media/tools/omx_test/color_space_util.h View 1 chunk +0 lines, -24 lines 0 comments Download
D media/tools/omx_test/color_space_util.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D media/tools/omx_test/file_reader_util.h View 1 chunk +0 lines, -123 lines 0 comments Download
D media/tools/omx_test/file_reader_util.cc View 1 chunk +0 lines, -296 lines 0 comments Download
D media/tools/omx_test/file_sink.h View 1 chunk +0 lines, -60 lines 0 comments Download
D media/tools/omx_test/file_sink.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D media/tools/omx_test/omx_test.cc View 1 chunk +0 lines, -412 lines 0 comments Download
M media/tools/player_x11/player_x11.cc View 4 chunks +3 lines, -20 lines 0 comments Download
D media/video/omx_video_decode_engine.h View 1 chunk +0 lines, -246 lines 0 comments Download
D media/video/omx_video_decode_engine.cc View 1 chunk +0 lines, -1357 lines 0 comments Download
M webkit/support/webkit_support.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
scherkus (not reviewing)
fischman/vrk: sanity checks to make sure I'm not removing anything you use hclam: you helped ...
9 years, 6 months ago (2011-06-03 00:24:33 UTC) #1
scherkus (not reviewing)
...also 26 files changed, 5 insertions(+), 4619 deletions(-) RAWRRRRRRRRRRRRRRRRRRRRRRRR
9 years, 6 months ago (2011-06-03 00:24:51 UTC) #2
Alpha Left Google
LGTM!
9 years, 6 months ago (2011-06-03 00:38:24 UTC) #3
scherkus (not reviewing)
brettw: content/renderer, content/browser OWNERS
9 years, 6 months ago (2011-06-03 01:28:34 UTC) #4
Ami GONE FROM CHROMIUM
LGTM for what it is (which is awesome) but Sonny Rao was trying to revive ...
9 years, 6 months ago (2011-06-03 02:19:30 UTC) #5
brettw
content owners lgtm
9 years, 6 months ago (2011-06-03 02:59:48 UTC) #6
Alexander Potapenko
Looks like this CL has broken the heapchecker bot, which fails to compile media_unittests now. ...
9 years, 5 months ago (2011-06-28 10:25:57 UTC) #7
Alexander Potapenko
9 years, 5 months ago (2011-06-28 10:26:35 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698