Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2853)

Unified Diff: base/file_util_proxy.cc

Issue 7066067: Support creating temporary files for sync file operations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Darin's comments Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/file_util_proxy.h ('k') | content/browser/renderer_host/redirect_to_file_resource_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_util_proxy.cc
diff --git a/base/file_util_proxy.cc b/base/file_util_proxy.cc
index 1d5b9cc3cea8ca3b11d232c2a10f87b5c5dba582..cff76bdec8311c06f85cf723c478d085b9d47c62 100644
--- a/base/file_util_proxy.cc
+++ b/base/file_util_proxy.cc
@@ -167,8 +167,10 @@ class RelayCreateTemporary : public MessageLoopRelay {
public:
RelayCreateTemporary(
scoped_refptr<base::MessageLoopProxy> message_loop_proxy,
+ int additional_file_flags,
base::FileUtilProxy::CreateTemporaryCallback* callback)
: message_loop_proxy_(message_loop_proxy),
+ additional_file_flags_(additional_file_flags),
callback_(callback),
file_handle_(base::kInvalidPlatformFileValue) {
DCHECK(callback);
@@ -185,13 +187,12 @@ class RelayCreateTemporary : public MessageLoopRelay {
// that returns a FilePath and a PlatformFile.
file_util::CreateTemporaryFile(&file_path_);
- // Use a fixed set of flags that are appropriate for writing to a temporary
- // file from the IO thread using a net::FileStream.
int file_flags =
- base::PLATFORM_FILE_CREATE_ALWAYS |
base::PLATFORM_FILE_WRITE |
- base::PLATFORM_FILE_ASYNC |
- base::PLATFORM_FILE_TEMPORARY;
+ base::PLATFORM_FILE_TEMPORARY |
+ base::PLATFORM_FILE_CREATE_ALWAYS |
+ additional_file_flags_;
+
base::PlatformFileError error_code = base::PLATFORM_FILE_OK;
file_handle_ = base::CreatePlatformFile(file_path_, file_flags,
NULL, &error_code);
@@ -206,6 +207,7 @@ class RelayCreateTemporary : public MessageLoopRelay {
private:
scoped_refptr<base::MessageLoopProxy> message_loop_proxy_;
+ int additional_file_flags_;
base::FileUtilProxy::CreateTemporaryCallback* callback_;
base::PlatformFile file_handle_;
FilePath file_path_;
@@ -742,9 +744,12 @@ bool FileUtilProxy::CreateOrOpen(
// static
bool FileUtilProxy::CreateTemporary(
scoped_refptr<MessageLoopProxy> message_loop_proxy,
+ int additional_file_flags,
CreateTemporaryCallback* callback) {
return Start(FROM_HERE, message_loop_proxy,
- new RelayCreateTemporary(message_loop_proxy, callback));
+ new RelayCreateTemporary(message_loop_proxy,
+ additional_file_flags,
+ callback));
}
// static
« no previous file with comments | « base/file_util_proxy.h ('k') | content/browser/renderer_host/redirect_to_file_resource_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698