Compress sources of JS libraries in addition to the snapshot.

samples/shell.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 291 matching lines @@
     }
   }
 
 #ifdef COMPRESS_STARTUP_DATA_BZ2
   ASSERT_EQ(v8::StartupData::kBZip2,
             v8::V8::GetCompressedStartupDataAlgorithm());
   int compressed_data_count = v8::V8::GetCompressedStartupDataCount();
   v8::StartupData* compressed_data = new v8::StartupData[compressed_data_count];
   v8::V8::GetCompressedStartupData(compressed_data);
   for (int i = 0; i < compressed_data_count; ++i) {
-    char* decompressed = new char[compressed_data[i].raw_size];
     unsigned int decompressed_size = compressed_data[i].raw_size;
-    int result =
-        BZ2_bzBuffToBuffDecompress(decompressed,
-                                   &decompressed_size,
-                                   const_cast<char*>(compressed_data[i].data),
-                                   compressed_data[i].compressed_size,
-                                   0, 1);
-    if (result != BZ_OK) {
-      fprintf(stderr, "bzip error code: %d\n", result);
-      exit(1);
+    char* decompressed = new char[decompressed_size];
+    if (compressed_data[i].compressed_size != 0) {

[Vitaly Repeshko, 2011/06/06 10:08:23]

When does this happen?

[mnaganov (inactive), 2011/06/06 13:40:18]

When there is no snapshot. See snapshot-empty.cc.

+      int result =
+          BZ2_bzBuffToBuffDecompress(decompressed,
+                                     &decompressed_size,
+                                     const_cast<char*>(compressed_data[i].data),
+                                     compressed_data[i].compressed_size,
+                                     0, 1);
+      if (result != BZ_OK) {
+        fprintf(stderr, "bzip error code: %d\n", result);
+        exit(1);
+      }
     }
     compressed_data[i].data = decompressed;

[Vitaly Repeshko, 2011/06/06 10:08:23]

It seems strange that we assign a block of fresh uninitialized memory here in
case compressed_size is 0.

[mnaganov (inactive), 2011/06/06 13:40:18]

We should never read from it in this case. I've added an assertion that in this
case raw_ (decompressed) size, must also be 0.

     compressed_data[i].raw_size = decompressed_size;
   }
   v8::V8::SetDecompressedStartupData(compressed_data);
 #endif  // COMPRESS_STARTUP_DATA_BZ2
 
   v8::V8::SetFlagsFromCommandLine(&argc, argv, true);
   int result = 0;
   if (FLAG_stress_opt || FLAG_stress_deopt) {
     v8::Testing::SetStressRunType(FLAG_stress_opt
                                   ? v8::Testing::kStressTypeOpt
@@ skipping 336 matching lines @@
       printf("^");
     }
     printf("\n");
     v8::String::Utf8Value stack_trace(try_catch->StackTrace());
     if (stack_trace.length() > 0) {
       const char* stack_trace_string = ToCString(stack_trace);
       printf("%s\n", stack_trace_string);
     }
   }
 }