Issue 7066043: Cache Autofill heuristics regexes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7066043: Cache Autofill heuristics regexes (Closed)

Created:
9 years, 6 months ago by Ilya Sherman

Modified:
9 years, 6 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, GeorgeY, Ilya Sherman, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Cache Autofill heuristics regexes Runtime for FormStructureBrowserTest.DataDrivenHeuristics decreased from 2.4s to 1.5s In particular, the test now spends 61ms in AutofillManager::ParseForms, down from 738ms. BUG=72242 TEST=unit_tests --gtest_filter=Autofill*:FormStructure*, browser_tests --gtest_filter=Autofill*:FormStructure* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87710

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+114 lines, -35 lines)			Patch
A	chrome/browser/autofill/autofill_regexes.h	View	1 chunk	+20 lines, -0 lines	0 comments	Download
A	chrome/browser/autofill/autofill_regexes.cc	View	1 chunk	+84 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/autofill_scanner.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/autofill/autofill_scanner.cc	View	2 chunks	+0 lines, -19 lines	0 comments	Download
M	chrome/browser/autofill/credit_card.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/autofill/form_field.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/autofill/personal_data_manager.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dhollowa

9 years, 6 months ago (2011-06-02 15:52:22 UTC) #2

LGTM.  Expect this to need a Valgrind suppression however.

Expand Messages | Collapse Messages