Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: chrome/browser/ui/tab_contents/tab_contents_wrapper.h

Issue 7066039: Remove dependency on PrefChangeRegistrar and renderer_preferences_util from content. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tab_contents/tab_contents_wrapper.h
===================================================================
--- chrome/browser/ui/tab_contents/tab_contents_wrapper.h (revision 86494)
+++ chrome/browser/ui/tab_contents/tab_contents_wrapper.h (working copy)
@@ -12,6 +12,7 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/prefs/pref_change_registrar.h"
#include "chrome/browser/printing/print_view_manager.h"
#include "content/browser/tab_contents/tab_contents.h"
#include "content/browser/tab_contents/tab_contents_observer.h"
@@ -174,6 +175,7 @@
// Overrides -----------------------------------------------------------------
// TabContentsObserver overrides:
+ virtual void RenderViewCreated(RenderViewHost* render_view_host);
Avi (use Gerrit) 2011/05/25 02:34:34 OVERRIDE
jam 2011/05/25 16:00:59 Done.
virtual void RenderViewGone() OVERRIDE;
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
@@ -213,6 +215,20 @@
void OnSnapshot(const SkBitmap& bitmap);
void OnPDFHasUnsupportedFeature();
+ // Returns the server that can provide alternate error pages. If the returned
+ // URL is empty, the default error page built into WebKit will be used.
+ GURL GetAlternateErrorPageURL() const;
+
+ // Send the alternate error page URL to the renderer. This method is virtual
+ // so special html pages can override this (e.g., the new tab page).
Avi (use Gerrit) 2011/05/25 02:34:34 html → HTML This doesn't look virtual to me. What
jam 2011/05/25 16:00:59 I had copied the comment without reading it till t
+ void UpdateAlternateErrorPageURL(RenderViewHost* rvh);
+
+ // Update the RenderView's WebPreferences.
+ void UpdateWebPreferences();
+
+ // Update the TabContents's RendererPreferences.
+ void UpdateRendererPreferences();
+
// Data for core operation ---------------------------------------------------
// Delegate for notifying our owner about stuff. Not owned by us.
@@ -223,6 +239,7 @@
bool infobars_enabled_;
NotificationRegistrar registrar_;
+ PrefChangeRegistrar pref_change_registrar_;
// Data for current page -----------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698