Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7066039: Remove dependency on PrefChangeRegistrar and renderer_preferences_util from content. (Closed)

Created:
9 years, 7 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Remove dependency on PrefChangeRegistrar and renderer_preferences_util from content. BUG=76697 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86679

Patch Set 1 : '' #

Patch Set 2 : '' #

Total comments: 8

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : sync #

Patch Set 5 : also remove predictor_api.h #

Total comments: 1

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -186 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_view_host_observer.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_view_host_observer.cc View 1 2 3 4 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/chrome_interstitial_page.cc View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.h View 1 2 3 4 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 1 2 3 8 chunks +102 lines, -0 lines 0 comments Download
M content/browser/DEPS View 1 2 3 4 3 chunks +0 lines, -4 lines 0 comments Download
M content/browser/content_browser_client.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/content_browser_client.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 3 4 5 3 chunks +0 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 1 2 3 3 chunks +3 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_view_host_observer.h View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_observer.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/tab_contents/interstitial_page.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/tab_contents/interstitial_page.cc View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 2 3 4 chunks +0 lines, -15 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 3 4 5 9 chunks +3 lines, -106 lines 0 comments Download
M content/browser/tab_contents/tab_contents_observer.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_observer.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jam
9 years, 7 months ago (2011-05-25 00:26:03 UTC) #1
Avi (use Gerrit)
http://codereview.chromium.org/7066039/diff/11004/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc File chrome/browser/ui/tab_contents/tab_contents_wrapper.cc (right): http://codereview.chromium.org/7066039/diff/11004/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc#newcode68 chrome/browser/ui/tab_contents/tab_contents_wrapper.cc:68: }; This is a significantly shorter list than the ...
9 years, 7 months ago (2011-05-25 02:34:34 UTC) #2
jam
http://codereview.chromium.org/7066039/diff/11004/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc File chrome/browser/ui/tab_contents/tab_contents_wrapper.cc (right): http://codereview.chromium.org/7066039/diff/11004/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc#newcode68 chrome/browser/ui/tab_contents/tab_contents_wrapper.cc:68: }; On 2011/05/25 02:34:34, Avi wrote: > This is ...
9 years, 7 months ago (2011-05-25 16:00:59 UTC) #3
Avi (use Gerrit)
LGTM with fix http://codereview.chromium.org/7066039/diff/13013/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc File chrome/browser/ui/tab_contents/tab_contents_wrapper.cc (right): http://codereview.chromium.org/7066039/diff/13013/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc#newcode535 chrome/browser/ui/tab_contents/tab_contents_wrapper.cc:535: // Disable alternate error pages when ...
9 years, 7 months ago (2011-05-25 16:22:04 UTC) #4
jam
Can you please have another look at the difference between patchset 4 and 5? I ...
9 years, 7 months ago (2011-05-25 17:30:39 UTC) #5
Avi (use Gerrit)
9 years, 7 months ago (2011-05-25 17:50:25 UTC) #6 
LGTM with fix

http://codereview.chromium.org/7066039/diff/9033/content/browser/renderer_hos...
File content/browser/renderer_host/render_view_host_observer.h (right):

http://codereview.chromium.org/7066039/diff/9033/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host_observer.h:32: // Notifies that a
navigatoin is starting.
typo

Powered by Google App Engine
This is Rietveld 408576698