Enable cross-filesystem moves and copies.

Enable cross-filesystem moves and copies.

BUG=none
TEST=unit tests included; I also tested locally with a cross-filesystem-sync-copy layout test [that I'll add to webkit later], both with and without obfuscation.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86755

[ericu, 2011-05-24 23:35:29]

+cc dmikurube@

[ericu, 2011-05-25 03:22:49]

Apparently I got confused by overlapping try jobs and the last change wasn't
actually necessary to fix the bots.

[michaeln, 2011-05-25 19:27:57]

lgtm!

http://codereview.chromium.org/7066033/diff/7002/webkit/fileapi/file_system_f...
File webkit/fileapi/file_system_file_util.cc (right):

http://codereview.chromium.org/7066033/diff/7002/webkit/fileapi/file_system_f...
webkit/fileapi/file_system_file_util.cc:228: FileSystemOperationContext
local_dest_context(
A comment about why you need a local_dest_context would be good.

http://codereview.chromium.org/7066033/diff/7002/webkit/fileapi/file_system_f...
webkit/fileapi/file_system_file_util.cc:251: if (dest_parent !=
FilePath(FILE_PATH_LITERAL(".")) &&
I get it, but odd looking case testing for ".", maybe make a local helper since
this odd check is done twice...

bool DoesDirectoryExist(FilePath dir, dest_util, dest_context);

http://codereview.chromium.org/7066033/diff/7002/webkit/fileapi/file_system_f...
File webkit/fileapi/file_system_file_util_unittest.cc (right):

http://codereview.chromium.org/7066033/diff/7002/webkit/fileapi/file_system_f...
webkit/fileapi/file_system_file_util_unittest.cc:178: result =
base::PLATFORM_FILE_OK;
maybe expected_result

[ericu, 2011-05-25 19:56:20]

I also removed that unnecessary extra unlimited quota change.

http://codereview.chromium.org/7066033/diff/7002/webkit/fileapi/file_system_f...
File webkit/fileapi/file_system_file_util.cc (right):

http://codereview.chromium.org/7066033/diff/7002/webkit/fileapi/file_system_f...
webkit/fileapi/file_system_file_util.cc:228: FileSystemOperationContext
local_dest_context(
On 2011/05/25 19:27:57, michaeln wrote:
> A comment about why you need a local_dest_context would be good.

Done.

http://codereview.chromium.org/7066033/diff/7002/webkit/fileapi/file_system_f...
webkit/fileapi/file_system_file_util.cc:251: if (dest_parent !=
FilePath(FILE_PATH_LITERAL(".")) &&
On 2011/05/25 19:27:57, michaeln wrote:
> I get it, but odd looking case testing for ".", maybe make a local helper
since
> this odd check is done twice...
> 
> bool DoesDirectoryExist(FilePath dir, dest_util, dest_context);

Done: ParentExists().

http://codereview.chromium.org/7066033/diff/7002/webkit/fileapi/file_system_f...
File webkit/fileapi/file_system_file_util_unittest.cc (right):

http://codereview.chromium.org/7066033/diff/7002/webkit/fileapi/file_system_f...
webkit/fileapi/file_system_file_util_unittest.cc:178: result =
base::PLATFORM_FILE_OK;
On 2011/05/25 19:27:57, michaeln wrote:
> maybe expected_result

Done.

[michaeln, 2011-05-25 20:30:10]

thnx!

http://codereview.chromium.org/7066033/diff/7005/webkit/fileapi/file_system_f...
File webkit/fileapi/file_system_file_util.cc (right):

http://codereview.chromium.org/7066033/diff/7005/webkit/fileapi/file_system_f...
webkit/fileapi/file_system_file_util.cc:26: return false;
nit: maybe could be more readable...

FilePath parent = file_path.DirName();
if (parent == FilePath(FILE_PATH_LITERAL("."))
  return true;
return file_util->DirectoryExists(context, parent);

or

FilePath parent = file_path.DirName();
return parent == FilePath(FILE_PATH_LITERAL(".")) ||
       file_util->DirectoryExists(context, parent);

[commit-bot: I haz the power, 2011-05-25 21:03:03]

Try job failure for 7066033-7005 on mac:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[ericu, 2011-05-25 21:51:58]

http://codereview.chromium.org/7066033/diff/7005/webkit/fileapi/file_system_f...
File webkit/fileapi/file_system_file_util.cc (right):

http://codereview.chromium.org/7066033/diff/7005/webkit/fileapi/file_system_f...
webkit/fileapi/file_system_file_util.cc:26: return false;
On 2011/05/25 20:30:11, michaeln wrote:
> nit: maybe could be more readable...
> 
> FilePath parent = file_path.DirName();
> if (parent == FilePath(FILE_PATH_LITERAL("."))
>   return true;
> return file_util->DirectoryExists(context, parent);
> 
> or
> 
> FilePath parent = file_path.DirName();
> return parent == FilePath(FILE_PATH_LITERAL(".")) ||
>        file_util->DirectoryExists(context, parent);

Done.

[commit-bot: I haz the power, 2011-05-26 00:54:47]

Change committed as 86755