Fix most visited pages console spew.

Fix most visited pages console spew.

BUG=82824
TEST=doesn't say anything on startup

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86635

[tony, 2011-05-24 19:02:52]

http://codereview.chromium.org/7066029/diff/1/chrome/browser/ui/webui/ntp/mos...
File chrome/browser/ui/webui/ntp/most_visited_handler.cc (right):

http://codereview.chromium.org/7066029/diff/1/chrome/browser/ui/webui/ntp/mos...
chrome/browser/ui/webui/ntp/most_visited_handler.cc:356:
StartQueryForMostVisited();
We're only getting this spew because we got a notification while the first
history query was pending?  Does this result in an extra unnecessary DB query? 
If this query is needed (e.g., the results might have changed), then LGTM.

[Evan Stade, 2011-05-24 20:48:37]

On 2011/05/24 19:02:52, tony wrote:
>
http://codereview.chromium.org/7066029/diff/1/chrome/browser/ui/webui/ntp/mos...
> File chrome/browser/ui/webui/ntp/most_visited_handler.cc (right):
> 
>
http://codereview.chromium.org/7066029/diff/1/chrome/browser/ui/webui/ntp/mos...
> chrome/browser/ui/webui/ntp/most_visited_handler.cc:356:
> StartQueryForMostVisited();
> We're only getting this spew because we got a notification while the first
> history query was pending?

before the page had even loaded. SendPages does nothing if there is no page data
already returned.

>  Does this result in an extra unnecessary DB query? 

no. If the top sites DB loads before the most visited page handler, then we get
the initial data from the Query() call in the constructor. If top sites DB is
loaded after the most visited page handler is constructed, we get initial data
from the Query() call in the notification observer.

> If this query is needed (e.g., the results might have changed), then LGTM.

[tony, 2011-05-24 20:52:18]

Ok, LGTM!