Linux: call download_nacl_irt.py in export_tarball.py

tools/export_tarball/export_tarball.py

Index: tools/export_tarball/export_tarball.py
===================================================================
--- tools/export_tarball/export_tarball.py	(revision 86416)
+++ tools/export_tarball/export_tarball.py	(working copy)
@@ -18,6 +18,7 @@
 
 import optparse
 import os
+import subprocess
 import sys
 import tarfile
 
@@ -97,6 +98,16 @@
     print 'Cannot find the src directory.'
     return 1
 
+  nacl_download_path = \

[bradn, 2011/05/24 19:55:36]

Style guide discourages \
Do this instead:
nacl_download_path = os.path.join(
    GetSourceDirectory(), 'build', 'download_nacl_irt.py')

[Paweł Hajdan Jr., 2011/05/25 08:49:44]

Done.

+      os.path.join(GetSourceDirectory(), 'build', 'download_nacl_irt.py')
+  nacl_cwd = os.path.join(GetSourceDirectory(), '..')
+  if subprocess.call(['python', nacl_download_path], cwd=nacl_cwd) != 0:
+    # The error is not fatal - NaCl is still experimental.
+    print 'Failed to download NaCl integrated runtime files.'
+    print 'The NaCl-enabled build will fail. You can pass -Ddisable_nacl=1'
+    print 'to gyp as a workaround. For more info see'
+    print 'http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/1fe6e2c3f9e78c2b'

[bradn, 2011/05/24 19:55:36]

Use () to split.

[Paweł Hajdan Jr., 2011/05/25 08:49:44]

Done.

+
   output_fullname = args[0] + '.tar.bz2'
   output_basename = os.path.basename(args[0])