Linux: call download_nacl_irt.py in export_tarball.py

Linux: call download_nacl_irt.py in export_tarball.py
to make sure the generated tarballs can be built with NaCl support.

export_tarball.py is not the prettiest place for this,
but it's the easiest to modify (public repo),
and can easily be kept in sync with other scripts in the tree
in case anything changes.

BUG=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86583

[bradn, 2011-05-24 15:28:28]

Where does this script run?
So the tarball gets built without gyp generation running?

[Paweł Hajdan Jr., 2011-05-24 15:50:29]

It is run by cron on the buildbot master I think, and the results are stored on
http://build.chromium.org/official/

gyp generation is disabled because the host that generates the tarball is not
guaranteed to have all build deps (generating tarballs on a host that has all
required deps would be another solution, possibly better).

[nsylvain, 2011-05-24 16:35:49]

LGTM

[bradn, 2011-05-24 19:55:36]

Nits.
Otherwise LGTM, assuming mseaborn landed his change.

http://codereview.chromium.org/7066022/diff/1/tools/export_tarball/export_tar...
File tools/export_tarball/export_tarball.py (right):

http://codereview.chromium.org/7066022/diff/1/tools/export_tarball/export_tar...
tools/export_tarball/export_tarball.py:101: nacl_download_path = \
Style guide discourages \
Do this instead:
nacl_download_path = os.path.join(
    GetSourceDirectory(), 'build', 'download_nacl_irt.py')

http://codereview.chromium.org/7066022/diff/1/tools/export_tarball/export_tar...
tools/export_tarball/export_tarball.py:109: print
'http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/1fe6e2c3f9e78c2b'
>80
Use () to split.

[Paweł Hajdan Jr., 2011-05-25 08:49:43]

http://codereview.chromium.org/7066022/diff/1/tools/export_tarball/export_tar...
File tools/export_tarball/export_tarball.py (right):

http://codereview.chromium.org/7066022/diff/1/tools/export_tarball/export_tar...
tools/export_tarball/export_tarball.py:101: nacl_download_path = \
On 2011/05/24 19:55:36, bradn wrote:
> Style guide discourages \
> Do this instead:
> nacl_download_path = os.path.join(
>     GetSourceDirectory(), 'build', 'download_nacl_irt.py')

Done.

http://codereview.chromium.org/7066022/diff/1/tools/export_tarball/export_tar...
tools/export_tarball/export_tarball.py:109: print
'http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/1fe6e2c3f9e78c2b'
On 2011/05/24 19:55:36, bradn wrote:
> >80
> Use () to split.

Done.

[bradn, 2011-05-25 17:20:30]

lgtm