Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 7066015: Fix a bug in deoptimization on x64. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1374 matching lines...) Expand 10 before | Expand all | Expand 10 after
1385 result_saved = true; 1385 result_saved = true;
1386 } 1386 }
1387 switch (property->kind()) { 1387 switch (property->kind()) {
1388 case ObjectLiteral::Property::CONSTANT: 1388 case ObjectLiteral::Property::CONSTANT:
1389 UNREACHABLE(); 1389 UNREACHABLE();
1390 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1390 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1391 ASSERT(!CompileTimeValue::IsCompileTimeValue(value)); 1391 ASSERT(!CompileTimeValue::IsCompileTimeValue(value));
1392 // Fall through. 1392 // Fall through.
1393 case ObjectLiteral::Property::COMPUTED: 1393 case ObjectLiteral::Property::COMPUTED:
1394 if (key->handle()->IsSymbol()) { 1394 if (key->handle()->IsSymbol()) {
1395 VisitForAccumulatorValue(value);
1396 __ Move(rcx, key->handle());
1397 __ movq(rdx, Operand(rsp, 0));
1398 if (property->emit_store()) { 1395 if (property->emit_store()) {
1399 Handle<Code> ic = isolate()->builtins()->StoreIC_Initialize(); 1396 VisitForAccumulatorValue(value);
1397 __ Move(rcx, key->handle());
1398 __ movq(rdx, Operand(rsp, 0));
1399 Handle<Code> ic = is_strict_mode()
1400 ? isolate()->builtins()->StoreIC_Initialize_Strict()
1401 : isolate()->builtins()->StoreIC_Initialize();
1400 EmitCallIC(ic, RelocInfo::CODE_TARGET, key->id()); 1402 EmitCallIC(ic, RelocInfo::CODE_TARGET, key->id());
1401 PrepareForBailoutForId(key->id(), NO_REGISTERS); 1403 PrepareForBailoutForId(key->id(), NO_REGISTERS);
1404 } else {
1405 VisitForEffect(value);
1402 } 1406 }
1403 break; 1407 break;
1404 } 1408 }
1405 // Fall through. 1409 // Fall through.
1406 case ObjectLiteral::Property::PROTOTYPE: 1410 case ObjectLiteral::Property::PROTOTYPE:
1407 __ push(Operand(rsp, 0)); // Duplicate receiver. 1411 __ push(Operand(rsp, 0)); // Duplicate receiver.
1408 VisitForStackValue(key); 1412 VisitForStackValue(key);
1409 VisitForStackValue(value); 1413 VisitForStackValue(value);
1410 if (property->emit_store()) { 1414 if (property->emit_store()) {
1411 __ Push(Smi::FromInt(NONE)); // PropertyAttributes 1415 __ Push(Smi::FromInt(NONE)); // PropertyAttributes
(...skipping 2879 matching lines...) Expand 10 before | Expand all | Expand 10 after
4291 __ ret(0); 4295 __ ret(0);
4292 } 4296 }
4293 4297
4294 4298
4295 #undef __ 4299 #undef __
4296 4300
4297 4301
4298 } } // namespace v8::internal 4302 } } // namespace v8::internal
4299 4303
4300 #endif // V8_TARGET_ARCH_X64 4304 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698