Store information about invoked RunnableFunction on stack to aid debugging of canary channel cras...

base/task.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TASK_H_
 #define BASE_TASK_H_
 #pragma once
 
 #include "base/base_api.h"
+#include "base/debug/alias.h"
 #include "base/memory/raw_scoped_refptr_mismatch_checker.h"
 #include "base/memory/weak_ptr.h"
 #include "base/tracked.h"
 #include "base/tuple.h"
 
+namespace base {
+const size_t kDeadTask = 0xDEAD7A53;
+}
+
 // Task ------------------------------------------------------------------------
 //
 // A task is a generic runnable thingy, usually used for running code on a
 // different thread or for scheduling future tasks off of the message loop.
 
 class BASE_API Task : public tracked_objects::Tracked {
  public:
   Task();
   virtual ~Task();
 
@@ skipping 293 matching lines @@
   RunnableMethod(T* obj, Method meth, const Params& params)
       : obj_(obj), meth_(meth), params_(params) {
     traits_.RetainCallee(obj_);
     COMPILE_ASSERT(
         (base::internal::ParamsUseScopedRefptrCorrectly<Params>::value),
         badrunnablemethodparams);
   }
 
   ~RunnableMethod() {
     ReleaseCallee();
+    obj_ = reinterpret_cast<T*>(base::kDeadTask);
   }
 
   virtual void Run() {
     if (obj_)
       DispatchToMethod(obj_, meth_, params_);
   }
 
   virtual void Cancel() {
     ReleaseCallee();
   }
@@ skipping 107 matching lines @@
 class RunnableFunction : public Task {
  public:
   RunnableFunction(Function function, const Params& params)
       : function_(function), params_(params) {
     COMPILE_ASSERT(
         (base::internal::ParamsUseScopedRefptrCorrectly<Params>::value),
         badrunnablefunctionparams);
   }
 
   ~RunnableFunction() {
+    function_ = reinterpret_cast<Function>(base::kDeadTask);
   }
 
   virtual void Run() {
+    // TODO(apatrick): Remove this ASAP. This ensures that the function pointer
+    // is available in minidumps for the purpose of diagnosing 81449.

[darin (slow to review), 2011/05/24 04:45:19]

nit: prefix bug numbers with "bug" or "crbug.com/"

+    Function function = function_;
+    base::debug::Alias(&function);
+    Params params = params_;
+    base::debug::Alias(&params);
+
     if (function_)
       DispatchToFunction(function_, params_);
   }
 
  private:
   Function function_;
   Params params_;
 };
 
 template <class Function>
@@ skipping 57 matching lines @@
 template <class Function, class A, class B, class C, class D, class E,
           class F, class G, class H>
 inline Task* NewRunnableFunction(Function function, const A& a, const B& b,
                                  const C& c, const D& d, const E& e, const F& f,
                                  const G& g, const H& h) {
   return new RunnableFunction<Function, Tuple8<A, B, C, D, E, F, G, H> >(
       function, MakeTuple(a, b, c, d, e, f, g, h));
 }
 
 #endif  // BASE_TASK_H_