Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 7066006: Store information about invoked RunnableFunction on stack to aid debugging of canary channel cras... (Closed)

Created:
9 years, 7 months ago by apatrick_chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Store information about invoked RunnableFunction on stack to aid debugging of canary channel crashes. TEST=compiles BUG=81449 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86447

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M base/debug/alias.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M base/task.h View 1 2 3 chunks +14 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
awong
LGTM Can't hurt.
9 years, 7 months ago (2011-05-23 19:55:24 UTC) #1
apatrick_chromium
+darin for OWNERS
9 years, 7 months ago (2011-05-23 20:15:41 UTC) #2
apatrick_chromium
Patch set 3 should increase the likelihood of crashing in an identifiable way chrome runs ...
9 years, 7 months ago (2011-05-23 20:46:44 UTC) #3
awong
LGTM
9 years, 7 months ago (2011-05-23 21:07:05 UTC) #4
darin (slow to review)
9 years, 7 months ago (2011-05-24 04:45:19 UTC) #5
LGTM

http://codereview.chromium.org/7066006/diff/4/base/task.h
File base/task.h (right):

http://codereview.chromium.org/7066006/diff/4/base/task.h#newcode466
base/task.h:466: // is available in minidumps for the purpose of diagnosing
81449.
nit: prefix bug numbers with "bug" or "crbug.com/"

Powered by Google App Engine
This is Rietveld 408576698