Issue 7065074: git diff can have 'new file mode' for new files and 'new mode' for current files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7065074: git diff can have 'new file mode' for new files and 'new mode' for current files (Closed)

Created:
9 years, 6 months ago by M-A Ruel

Modified:
9 years, 6 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

git diff can have 'new file mode' for new files and 'new mode' for current files R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87979

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove redundant comments #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -11 lines)			Patch
	M	patch.py	View	1	4 chunks	+6 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

9 years, 6 months ago (2011-06-04 20:05:48 UTC) #2

LGTM.

http://codereview.chromium.org/7065074/diff/1/patch.py
File patch.py (right):

http://codereview.chromium.org/7065074/diff/1/patch.py#newcode249
patch.py:249: match = re.match(r'^new(| file) mode (\d{6})$', line)
Not sure the comment tells you anything the line doesn't already tell you.

Expand Messages | Collapse Messages