Improve large tab strip by leveraging touch icons when present

chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

Index: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
diff --git a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
index 1ae9b0f4adb6645577d946e7af47fae556e77b2e..f144a1b94595f0f7ec69bafbf9a210bb87a76867 100644
--- a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
+++ b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
@@ -328,7 +328,8 @@ void BrowserTabStripController::TabInsertedAt(TabContentsWrapper* contents,
   hover_tab_selector_.CancelTabTransition();
 
   TabRendererData data;
-  SetTabRendererDataFromModel(contents->tab_contents(), model_index, &data);
+  SetTabRendererDataFromModel(contents->tab_contents(), model_index, &data,
+      true);

[sky, 2011/06/16 15:43:41]

align with ( on 331.

[Emmanuel Saint-loubert-Bié, 2011/06/17 00:01:44]

OK I agree this is probably more readable. Here is what our coding guidelines
say, and I find this a bit confusing:

When calling a function, however, feel free to collapse things to take less
space.  Do whatever seems most readable.
     ThisIsARatherLongFunctionCall(
    first_lengthy_argument, second_argument, yet_another,
    more_arguments_here, okay_thats_enough);

ThisIsAnotherLongFunctionCall(first_lengthy_argument,
                              second_argument, yet_another);

AndAnotherLongFunctionCall(first_lengthy_argument,
    second_argument, yet_another);

AnotherLongFunctionCall(
    first_lengthy_argument,
    second_argument, yet_another);

bool result =
    YetAnotherLongFunctionCall(first_argument, second_argument);

   tabstrip_->AddTabAt(model_index, data);
 }
 
@@ -357,7 +358,8 @@ void BrowserTabStripController::TabMoved(TabContentsWrapper* contents,
 
   // Update the data first as the pinned state may have changed.
   TabRendererData data;
-  SetTabRendererDataFromModel(contents->tab_contents(), to_model_index, &data);
+  SetTabRendererDataFromModel(contents->tab_contents(), to_model_index, &data,
+      false);

[sky, 2011/06/16 15:43:41]

nit: align with ( on 361

[Emmanuel Saint-loubert-Bié, 2011/06/17 00:01:44]

Done.

   tabstrip_->SetTabData(from_model_index, data);
 
   tabstrip_->MoveTab(from_model_index, to_model_index);
@@ -404,14 +406,16 @@ void BrowserTabStripController::SetTabDataAt(
     TabContentsWrapper* contents,
     int model_index) {
   TabRendererData data;
-  SetTabRendererDataFromModel(contents->tab_contents(), model_index, &data);
+  SetTabRendererDataFromModel(contents->tab_contents(), model_index, &data,
+      false);

[sky, 2011/06/16 15:43:41]

nit: align with ( on 409.

   tabstrip_->SetTabData(model_index, data);
 }
 
 void BrowserTabStripController::SetTabRendererDataFromModel(
     TabContents* contents,
     int model_index,
-    TabRendererData* data) {
+    TabRendererData* data,
+    bool new_tab_insertion) {
   SkBitmap* app_icon = NULL;
   TabContentsWrapper* wrapper =
       TabContentsWrapper::GetCurrentWrapperForContents(contents);