Improve large tab strip by leveraging touch icons when present

content/browser/cancelable_request.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // CancelableRequestProviders and Consumers work together to make requests that
 // execute on a background thread in the provider and return data to the
 // consumer. These class collaborate to keep a list of open requests and to
 // make sure that requests to not outlive either of the objects involved in the
 // transaction.
 //
@@ skipping 220 matching lines @@
   T GetClientData(CancelableRequestProvider* p,
                   CancelableRequestProvider::Handle h);
 
   // Returns the data associated with the current request being processed. This
   // is only valid during the time a callback is being processed.
   T GetClientDataForCurrentRequest();
 
   // Returns true if there are any pending requests.
   bool HasPendingRequests() const;
 
+  // Returns true if there are any pending requests.
+  bool HasPendingRequestsForClientData(T client_data) const;
+
   // Returns the number of pending requests.
   size_t PendingRequestCount() const;
 
   // Cancels all requests outstanding.
   void CancelAllRequests();
 
+  // Cancels all requests outstanding matching the client data

[brettw, 2011/06/17 16:20:49]

Needs period.

[Emmanuel Saint-loubert-Bié, 2011/06/17 16:52:44]

Done.

+  void CancelAllRequestsForClientData(T client_data);
+
   // Returns the handle for the first request that has the specified client data
   // (in |handle|). Returns true if there is a request for the specified client
   // data, false otherwise.
   bool GetFirstHandleForClientData(T client_data,
                                    CancelableRequestProvider::Handle* handle);
 
   // Gets the client data for all pending requests.
   void GetAllClientData(std::vector<T>* data);
 
  protected:
@@ skipping 74 matching lines @@
   DCHECK(current_request_.is_valid());
   return GetClientData(current_request_.provider, current_request_.handle);
 }
 
 template<class T>
 bool CancelableRequestConsumerTSimple<T>::HasPendingRequests() const {
   return !pending_requests_.empty();
 }
 
 template<class T>
+bool CancelableRequestConsumerTSimple<T>::HasPendingRequestsForClientData(

[brettw, 2011/06/17 16:20:49]

Do we really need this function? In your single call site that uses it, it would
be better to remove. You're doing a brute-force search to find if there are any
requests, and then another brute-force search to remove them all. Why not just
skip the first one?

[Emmanuel Saint-loubert-Bié, 2011/06/17 16:52:44]

Done.

+    T client_data) const {
+  for (typename PendingRequestList::const_iterator i =
+           pending_requests_.begin(); i != pending_requests_.end(); ++i) {
+    if (i->second == client_data) {

[brettw, 2011/06/17 16:20:49]

No {} for single-line conditionals.

[Emmanuel Saint-loubert-Bié, 2011/06/17 16:52:44]

Done.

+      return true;
+    }
+  }
+  return false;
+}
+
+template<class T>
 size_t CancelableRequestConsumerTSimple<T>::PendingRequestCount() const {
   return pending_requests_.size();
 }
 
 template<class T>
 void CancelableRequestConsumerTSimple<T>::CancelAllRequests() {
   // TODO(atwilson): This code is not thread safe as it is called from the
   // consumer thread (via the destructor) and accesses pending_requests_
   // without acquiring the provider lock (http://crbug.com/85970).
   PendingRequestList copied_requests(pending_requests_);
   for (typename PendingRequestList::iterator i = copied_requests.begin();
        i != copied_requests.end(); ++i)
     i->first.provider->CancelRequest(i->first.handle);
   copied_requests.clear();
 
   // That should have cleared all the pending items.
   DCHECK(pending_requests_.empty());
 }
 
 template<class T>
+void CancelableRequestConsumerTSimple<T>::CancelAllRequestsForClientData(
+    T client_data) {
+  PendingRequestList copied_requests(pending_requests_);
+  for (typename PendingRequestList::const_iterator i = copied_requests.begin();
+      i != copied_requests.end(); ++i)

[brettw, 2011/06/17 16:20:49]

You should use {} for this for loop since it contains multiple lines
(Chrome-team style).

[Emmanuel Saint-loubert-Bié, 2011/06/17 16:52:44]

OK but this is a cut-and-paste from above :-) Which I will fix.

+    if (i->second == client_data)
+      i->first.provider->CancelRequest(i->first.handle);
+  copied_requests.clear();
+}
+
+template<class T>
 bool CancelableRequestConsumerTSimple<T>::GetFirstHandleForClientData(
     T client_data,
     CancelableRequestProvider::Handle* handle) {
   for (typename PendingRequestList::const_iterator i =
            pending_requests_.begin(); i != pending_requests_.end(); ++i) {
     if (i->second == client_data) {
       *handle = i->first.handle;
       return true;
     }
   }
@@ skipping 336 matching lines @@
   }
 
   // The value.
   Type value;
 
  protected:
   virtual ~CancelableRequest1() {}
 };
 
 #endif  // CONTENT_BROWSER_CANCELABLE_REQUEST_H_