Improve large tab strip by leveraging touch icons when present

chrome/browser/ui/touch/tabs/touch_tab_strip_controller.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_TOUCH_TABS_TOUCH_TAB_STRIP_CONTROLLER_H_
+#define CHROME_BROWSER_UI_TOUCH_TABS_TOUCH_TAB_STRIP_CONTROLLER_H_
+#pragma once
+
+#include "chrome/browser/favicon/favicon_service.h"
+#include "chrome/browser/history/history.h"
+#include "chrome/browser/ui/views/tabs/browser_tab_strip_controller.h"
+
+class TouchTab;
+class TouchTabStrip;
+
+// Subclassing BrowserTabStripController to provide touch specific behavior.

[brettw, 2011/06/17 16:20:49]

This comment seems like it just says the same thing the actual declaration does.
Can you write something a little more useful?

[Emmanuel Saint-loubert-Bié, 2011/06/17 16:52:44]

Done.

+class TouchTabStripController: public BrowserTabStripController {

[brettw, 2011/06/17 16:20:49]

Space before colon.

[Emmanuel Saint-loubert-Bié, 2011/06/17 16:52:44]

Done.

+ public:
+  TouchTabStripController(Browser* browser, TabStripModel* model);
+  virtual ~TouchTabStripController();
+
+  virtual void TabDetachedAt(TabContentsWrapper* contents,
+                             int model_index) OVERRIDE;
+
+  virtual void TabChangedAt(TabContentsWrapper* contents,
+                            int model_index,
+                            TabChangeType change_type) OVERRIDE;
+
+ protected:
+  virtual void SetTabRendererDataFromModel(TabContents* contents,
+                                           int model_index,
+                                           TabRendererData* data,
+                                           TabStatus tab_status) OVERRIDE;
+
+  const TouchTabStrip* tabstrip() const;
+
+ private:
+  void OnTouchIconAvailable(FaviconService::Handle h,
+                            history::FaviconData favicon);
+
+  // Our consumer for touch icon requests

[brettw, 2011/06/17 16:20:49]

Make sure your comments end with periods.

[Emmanuel Saint-loubert-Bié, 2011/06/17 16:52:44]

Done.

+  CancelableRequestConsumerTSimple<TouchTab*> consumer_;
+
+  DISALLOW_COPY_AND_ASSIGN(TouchTabStripController);
+};
+
+#endif  // CHROME_BROWSER_UI_TOUCH_TABS_TOUCH_TAB_STRIP_CONTROLLER_H_