Improve large tab strip by leveraging touch icons when present

chrome/browser/ui/views/tabs/browser_tab_strip_controller.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_TABS_BROWSER_TAB_STRIP_CONTROLLER_H_
 #define CHROME_BROWSER_UI_VIEWS_TABS_BROWSER_TAB_STRIP_CONTROLLER_H_
 #pragma once
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/tabs/tab_strip_model.h"
@@ skipping 79 matching lines @@
   virtual void TabMiniStateChanged(TabContentsWrapper* contents,
                                    int model_index) OVERRIDE;
   virtual void TabBlockedStateChanged(TabContentsWrapper* contents,
                                       int model_index) OVERRIDE;
 
   // NotificationObserver implementation:
   virtual void Observe(NotificationType type,
                        const NotificationSource& source,
                        const NotificationDetails& details) OVERRIDE;
 
+ protected:
+  // Sets the TabRendererData from the TabStripModel.
+  virtual void SetTabRendererDataFromModel(TabContents* contents,

[sky, 2011/06/16 15:43:41]

Position of definition should match that of declaration. So, since you moved
this you also need to move the definition in the .cc.

[Emmanuel Saint-loubert-Bié, 2011/06/17 00:01:44]

Done.

+                                           int model_index,
+                                           TabRendererData* data,
+                                           bool new_tab);

[sky, 2011/06/16 15:43:41]

Use an enum instead of a boolean.

[Emmanuel Saint-loubert-Bié, 2011/06/17 00:01:44]

Done.

+
+  Profile* profile() const { return model_->profile(); }
+
+  TabStripModel* model_;

[sky, 2011/06/16 15:43:41]

No protected members. Add protected accessors instead.

[Emmanuel Saint-loubert-Bié, 2011/06/17 00:01:44]

Done.

+
+  BaseTabStrip* tabstrip_;
+
+  // Non-owning pointer to the browser which is using this controller.
+  Browser* browser_;
+
  private:
   class TabContextMenuContents;
 
   // Invokes tabstrip_->SetTabData.
   void SetTabDataAt(TabContentsWrapper* contents, int model_index);
 
-  // Sets the TabRendererData from the TabStripModel.
-  void SetTabRendererDataFromModel(TabContents* contents,
-                                   int model_index,
-                                   TabRendererData* data);
-
   void StartHighlightTabsForCommand(
       TabStripModel::ContextMenuCommand command_id,
       BaseTab* tab);
   void StopHighlightTabsForCommand(
       TabStripModel::ContextMenuCommand command_id,
       BaseTab* tab);
 
-  Profile* profile() const { return model_->profile(); }
-
-  TabStripModel* model_;
-
-  BaseTabStrip* tabstrip_;
-
-  // Non-owning pointer to the browser which is using this controller.
-  Browser* browser_;
-
   // If non-NULL it means we're showing a menu for the tab.
   scoped_ptr<TabContextMenuContents> context_menu_contents_;
 
   NotificationRegistrar notification_registrar_;
 
   // Helper for performing tab selection as a result of dragging over a tab.
   HoverTabSelector hover_tab_selector_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserTabStripController);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_TABS_BROWSER_TAB_STRIP_CONTROLLER_H_