Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1470)

Unified Diff: content/plugin/plugin_channel.cc

Issue 7065048: Revert 86517 - Don't terminate plugin processes from the browser during browser shutdown. This is... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/plugin_process_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/plugin/plugin_channel.cc
===================================================================
--- content/plugin/plugin_channel.cc (revision 86530)
+++ content/plugin/plugin_channel.cc (working copy)
@@ -32,19 +32,9 @@
}
};
-class PluginProcessExitTask : public Task {
- public:
- void Run() {
- base::KillProcess(base::GetCurrentProcessHandle(), 0, false);
- }
-};
-
// How long we wait before releasing the plugin process.
const int kPluginReleaseTimeMs = 5 * 60 * 1000; // 5 minutes
-// How long we wait before forcibly shutting down the process.
-const int kPluginProcessTerminateTimeoutMs = 3000;
-
} // namespace
// If a sync call to the renderer results in a modal dialog, we need to have a
@@ -98,15 +88,6 @@
private:
void OnFilterAdded(IPC::Channel* channel) { channel_ = channel; }
- virtual void OnChannelError() {
- // Ensure that we don't wait indefinitely for the plugin to shutdown.
- // as the browser does not terminate plugin processes on shutdown.
- // We achieve this by posting an exit process task on the IO thread.
- MessageLoop::current()->PostDelayedTask(FROM_HERE,
- new PluginProcessExitTask(),
- kPluginProcessTerminateTimeoutMs);
- }
-
bool OnMessageReceived(const IPC::Message& message) {
IPC_BEGIN_MESSAGE_MAP(PluginChannel::MessageFilter, message)
IPC_MESSAGE_HANDLER_DELAY_REPLY(PluginMsg_Init, OnInit)
« no previous file with comments | « content/browser/plugin_process_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698