Issue 7065042: Hook up more of the NativeWidgetViews.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7065042: Hook up more of the NativeWidgetViews. (Closed)

Created:
9 years, 7 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Hook up more of the NativeWidgetViews. - Move NativeWidgetView to its own file. - Enhances the example to contain a button. http://crbug.com/83663 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86527

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+247 lines, -30 lines)			Patch
M	views/events/event.h	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	views/examples/native_widget_views_example.cc	View	1	3 chunks	+45 lines, -3 lines	1 comment	Download
M	views/views.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	views/widget/native_widget_view.h	View	1	1 chunk	+66 lines, -0 lines	0 comments	Download
A	views/widget/native_widget_view.cc	View		1 chunk	+108 lines, -0 lines	0 comments	Download
M	views/widget/native_widget_views.h	View	1	3 chunks	+17 lines, -7 lines	0 comments	Download
M	views/widget/native_widget_views.cc	View		2 chunks	+6 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

9 years, 7 months ago (2011-05-24 22:32:15 UTC) #2

LGTM

http://codereview.chromium.org/7065042/diff/6002/views/examples/native_widget...
File views/examples/native_widget_views_example.cc (right):

http://codereview.chromium.org/7065042/diff/6002/views/examples/native_widget...
views/examples/native_widget_views_example.cc:24: button_(new
views::TextButton(this, L"Click me!")) {
ALLOW_THIS_IN_INITIALIAZER_LIST

Expand Messages | Collapse Messages