Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 7065041: Fix OperatingSystemName and OperatingSystemVersion on Mac (Closed)

Created:
9 years, 7 months ago by stuartmorgan
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jam, pam+watch_chromium.org, Jói, apatrick_chromium, brettw-cc_chromium.org, Zhenyao Mo
Visibility:
Public.

Description

Fix OperatingSystemName and OperatingSystemVersion on Mac Prior to this change the posix implementations are used, so the return values are "Darwin" and the Darwin version. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M base/sys_info_mac.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M base/sys_info_posix.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_blacklist.cc View 1 chunk +1 line, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
stuartmorgan
I'll let the UMA folks know this is coming.
9 years, 7 months ago (2011-05-24 22:04:34 UTC) #1
Mark Mentovai
LGTM
9 years, 7 months ago (2011-05-24 22:16:31 UTC) #2
stuartmorgan
Argh, someday I'll get the hang of owners again. +kbr for gpu owner satisfaction
9 years, 7 months ago (2011-05-25 16:27:16 UTC) #3
Ken Russell (switch to Gerrit)
LGTM
9 years, 7 months ago (2011-05-25 19:34:28 UTC) #4
commit-bot: I haz the power
9 years, 7 months ago (2011-05-25 20:53:21 UTC) #5
Change committed as 86698

Powered by Google App Engine
This is Rietveld 408576698