Issue 7065037: Fix crash when creating a desktop shortcut for apps with a missing icon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7065037: Fix crash when creating a desktop shortcut for apps with a missing icon. (Closed)

Created:
9 years, 7 months ago by jstritar

Modified:
9 years, 6 months ago

Reviewers:
skerner, Sam Kerner (Chrome), commit-bot: I haz the power

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix crash when creating a desktop shortcut for apps with missing icons (use the default app icon instead). BUG=79282 TEST=See bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86665

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -19 lines)			Patch
M	chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/create_application_shortcut_view.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/extension_icon_source.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/extension_icon_source.cc	View	2 chunks	+11 lines, -10 lines	0 comments	Download

Total messages: 3 (0 generated)

Change committed as 86665