Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: remoting/client/plugin/chromoting_scriptable_object.h

Issue 7065036: Add basic versioning check to Chromoting's plugin/JS code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove logging Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/plugin/chromoting_scriptable_object.h
diff --git a/remoting/client/plugin/chromoting_scriptable_object.h b/remoting/client/plugin/chromoting_scriptable_object.h
index 8ee2d12ff8d047e10415ed426365aa9fb05ea5c4..0f4d249d2b0043c5dee0f9aa821a04cf6d000233 100644
--- a/remoting/client/plugin/chromoting_scriptable_object.h
+++ b/remoting/client/plugin/chromoting_scriptable_object.h
@@ -7,28 +7,19 @@
//
// interface ChromotingScriptableObject {
//
-// // Dimension of the desktop area.
-// readonly attribute int desktopWidth;
-// readonly attribute int desktopHeight;
+// // Chromoting session API version (for this plugin).
+// // This is compared with the javascript API version to verify that they are
+// // compatible.
+// readonly attribute unsigned short apiVersion;
+//
+// // The oldest API version that we support.
+// // This will differ from |apiVersion| if we decide to maintain backward
+// // compatibility with older API versions.
+// readonly attribute unsigned short apiMinVersion;
//
// // Connection status.
// readonly attribute unsigned short status;
//
-// // Statistics.
-// // Video Bandwidth in bytes per second.
-// readonly attribute float videoBandwidth;
-// // Latency for capturing in milliseconds.
-// readonly attribute int videoCaptureLatency;
-// // Latency for video encoding in milliseconds.
-// readonly attribute int videoEncodeLatency;
-// // Latency for video decoding in milliseconds.
-// readonly attribute int videoDecodeLatency;
-// // Latency for rendering in milliseconds.
-// readonly attribute int videoRenderLatency;
-// // Latency between an event is sent and a corresponding video packet is
-// // received.
-// readonly attribute int roundTripLatency;
-//
// // Constants for connection status.
// const unsigned short STATUS_UNKNOWN = 0;
// const unsigned short STATUS_CONNECTING = 1;
@@ -39,6 +30,7 @@
//
// // Connection quality.
// readonly attribute unsigned short quality;
+//
// // Constants for connection quality
// const unsigned short QUALITY_UNKNOWN = 0;
// const unsigned short QUALITY_GOOD = 1;
@@ -52,14 +44,7 @@
// // in the client UI.
// attribute Function debugInfo;
//
-// // JS callback function to send an XMPP IQ stanza for performing the
-// // signaling in a jingle connection. The callback function should be
-// // of type void(string request_xml).
-// attribute Function sendIq;
-//
-// // Method for receiving an XMPP IQ stanza in response to a previous
-// // sendIq() invocation. Other packets will be silently dropped.
-// void onIq(string response_xml);
+// attribute Function desktopSizeUpdate;
//
// // This function is called when login information for the host machine is
// // needed.
@@ -72,6 +57,30 @@
// // later case |connection_status| is changed to STATUS_FAILED.
// attribute Function loginChallenge;
//
+// // JS callback function to send an XMPP IQ stanza for performing the
+// // signaling in a jingle connection. The callback function should be
+// // of type void(string request_xml).
+// attribute Function sendIq;
+//
+// // Dimension of the desktop area.
+// readonly attribute int desktopWidth;
+// readonly attribute int desktopHeight;
+//
+// // Statistics.
+// // Video Bandwidth in bytes per second.
+// readonly attribute float videoBandwidth;
+// // Latency for capturing in milliseconds.
+// readonly attribute int videoCaptureLatency;
+// // Latency for video encoding in milliseconds.
+// readonly attribute int videoEncodeLatency;
+// // Latency for video decoding in milliseconds.
+// readonly attribute int videoDecodeLatency;
+// // Latency for rendering in milliseconds.
+// readonly attribute int videoRenderLatency;
+// // Latency between an event is sent and a corresponding video packet is
+// // received.
+// readonly attribute int roundTripLatency;
+//
// // Methods for establishing a Chromoting connection.
// //
// // Either use connect() or connectSandboxed(), not both. If using
@@ -87,6 +96,10 @@
//
// // Method for setting scale-to-fit.
// void setScaleToFit(bool scale_to_fit);
+//
+// // Method for receiving an XMPP IQ stanza in response to a previous
+// // sendIq() invocation. Other packets will be silently dropped.
+// void onIq(string response_xml);
// }
#ifndef REMOTING_CLIENT_PLUGIN_CHROMOTING_SCRIPTABLE_OBJECT_H_
@@ -151,7 +164,7 @@ class ChromotingScriptableObject
void SignalLoginChallenge();
// Attaches the XmppProxy used for issuing and receivng IQ stanzas for
- // initiaing a jingle connection from within the sandbox.
+ // initializing a jingle connection from within the sandbox.
void AttachXmppProxy(PepperXmppProxy* xmpp_proxy);
// Sends an IQ stanza, serialized as an xml string, into Javascript for

Powered by Google App Engine
This is Rietveld 408576698