Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 7065036: Add basic versioning check to Chromoting's plugin/JS code. (Closed)

Created:
9 years, 7 months ago by garykac
Modified:
9 years, 6 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Add basic versioning check to Chromoting's plugin/JS code. Fixup order of elements in the ScriptableObject interface header. It's supposed to match the .CC file but had gotten seriously out of sync. BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86655

Patch Set 1 #

Patch Set 2 : remove logging #

Total comments: 2

Patch Set 3 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -0 lines) Patch
M remoting/client/appengine/static_files/chromoting_session.js View 1 2 3 chunks +21 lines, -0 lines 0 comments Download
M remoting/client/plugin/chromoting_scriptable_object.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M remoting/client/plugin/chromoting_scriptable_object.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M remoting/webapp/me2mom/remoting_session.js View 1 3 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
garykac
9 years, 7 months ago (2011-05-24 21:14:24 UTC) #1
Jamie
Reordering things to improve consistency is worth doing, but can we make it a separate ...
9 years, 7 months ago (2011-05-25 00:29:34 UTC) #2
garykac
Moved comment reorg into separate cl http://codereview.chromium.org/7065036/diff/1005/remoting/client/appengine/static_files/chromoting_session.js File remoting/client/appengine/static_files/chromoting_session.js (right): http://codereview.chromium.org/7065036/diff/1005/remoting/client/appengine/static_files/chromoting_session.js#newcode12 remoting/client/appengine/static_files/chromoting_session.js:12: chromoting.apiVersion = 42; ...
9 years, 7 months ago (2011-05-25 16:39:43 UTC) #3
Jamie
LGTM.
9 years, 7 months ago (2011-05-25 16:45:15 UTC) #4
commit-bot: I haz the power
9 years, 7 months ago (2011-05-25 18:19:20 UTC) #5
Change committed as 86655

Powered by Google App Engine
This is Rietveld 408576698