chrome/test/data/extensions/api_test/content_settings/incognito/test.html - Issue 7065033: Support persistent incognito preferences

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/content_settings/incognito/test.html

Issue 7065033: Support persistent incognito preferences (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/samples.json ('k') | chrome/test/data/extensions/api_test/content_settings/onchange/test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/content_settings/incognito/test.html

diff --git a/chrome/test/data/extensions/api_test/content_settings/incognito/test.html b/chrome/test/data/extensions/api_test/content_settings/incognito/test.html

index ab3b65393bcc357f6d80e78475a26e2f7bec8514..b16f8c0907e2a7833269b2ff1cf95307e364a3e6 100644

--- a/chrome/test/data/extensions/api_test/content_settings/incognito/test.html

+++ b/chrome/test/data/extensions/api_test/content_settings/incognito/test.html

@@ -25,11 +25,10 @@ chrome.test.runTests([

'levelOfControl': "ControllableByThisExtension" },

"third-party cookies should not be blocked in incognito mode"));

- // TODO(battre): re-enable when incognito preferences are available again.

- /*

function set() {

cs.misc.blockThirdPartyCookies.set(

- { 'incognito': true, 'value': true }, chrome.test.callbackPass());

+ { 'scope': 'incognito_persistent', 'value': true },

+ chrome.test.callbackPass());

function getRegular2() {

cs.misc.blockThirdPartyCookies.get(

@@ -46,6 +45,5 @@ chrome.test.runTests([

'levelOfControl': "ControlledByThisExtension" },

"third-party cookies should be blocked in incognito mode"));

- */

]);

</script>