Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4597)

Unified Diff: chrome/browser/extensions/extension_prefs.h

Issue 7065033: Support persistent incognito preferences (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_preference_api.cc ('k') | chrome/browser/extensions/extension_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_prefs.h
diff --git a/chrome/browser/extensions/extension_prefs.h b/chrome/browser/extensions/extension_prefs.h
index 7414608f862d3bc14f0c610b201f0f0b47303430..55e87a71a193522034c6c73e558e76f4e9229e89 100644
--- a/chrome/browser/extensions/extension_prefs.h
+++ b/chrome/browser/extensions/extension_prefs.h
@@ -13,6 +13,7 @@
#include "base/memory/linked_ptr.h"
#include "base/time.h"
#include "chrome/browser/extensions/extension_content_settings_store.h"
+#include "chrome/browser/extensions/extension_prefs_scope.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/common/extensions/extension.h"
#include "googleurl/src/gurl.h"
@@ -303,12 +304,12 @@ class ExtensionPrefs : public ExtensionContentSettingsStore::Observer {
// Takes ownership of |value|.
void SetExtensionControlledPref(const std::string& extension_id,
const std::string& pref_key,
- bool incognito,
+ extension_prefs_scope::Scope scope,
Value* value);
void RemoveExtensionControlledPref(const std::string& extension_id,
const std::string& pref_key,
- bool incognito);
+ extension_prefs_scope::Scope scope);
// Returns true if currently no extension with higher precedence controls the
// preference.
@@ -415,7 +416,8 @@ class ExtensionPrefs : public ExtensionContentSettingsStore::Observer {
// or creates a new one. All entries in the dictionary contain non-expanded
// paths.
const DictionaryValue* GetExtensionControlledPrefs(
- const std::string& id) const;
+ const std::string& id,
+ bool incognito) const;
// Serializes the data and schedules a persistent save via the |PrefService|.
// TODO(andybons): Fire an EXTENSION_PREF_CHANGED notification to be more
« no previous file with comments | « chrome/browser/extensions/extension_preference_api.cc ('k') | chrome/browser/extensions/extension_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698