chrome/common/extensions/docs/examples/extensions/proxy_configuration/proxy_form_controller.js - Issue 7065033: Support persistent incognito preferences

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/examples/extensions/proxy_configuration/proxy_form_controller.js

Issue 7065033: Support persistent incognito preferences (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_preference_api.cc ('K') | « chrome/common/extensions/docs/examples/extensions/proxy_configuration/popup.html ('k') | chrome/common/extensions/docs/preferences.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/examples/extensions/proxy_configuration/proxy_form_controller.js

diff --git a/chrome/common/extensions/docs/examples/extensions/proxy_configuration/proxy_form_controller.js b/chrome/common/extensions/docs/examples/extensions/proxy_configuration/proxy_form_controller.js

index 3dbddaabd15de8c46f0ff5ff10db856a324fa425..bb48dd461284daef5608a0e4f3bd022ba012ce05 100644

--- a/chrome/common/extensions/docs/examples/extensions/proxy_configuration/proxy_form_controller.js

+++ b/chrome/common/extensions/docs/examples/extensions/proxy_configuration/proxy_form_controller.js

@@ -525,10 +525,9 @@ ProxyFormController.prototype = {

return;

}

if (this.config_.incognito) {

- // TODO(battre): change incognito value once available

- // chrome.proxy.settings.set(

- // {value: this.config_.incognito, scope: 'incognito'},

- // this.callbackForIncognitoSettings_.bind(this));

+ chrome.proxy.settings.set(

+ {value: this.config_.incognito, scope: 'incognito_persistent'},

+ this.callbackForIncognitoSettings_.bind(this));

} else {

ProxyFormController.setPersistedSettings(this.config_);

this.generateAlert_(chrome.i18n.getMessage('successfullySetProxy'));