Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/extension_proxy_apitest.cc

Issue 7065033: Support persistent incognito preferences (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/extension_pref_value_map.cc ('K') | « chrome/browser/extensions/extension_prefs_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_proxy_apitest.cc
diff --git a/chrome/browser/extensions/extension_proxy_apitest.cc b/chrome/browser/extensions/extension_proxy_apitest.cc
index 060e3fcf133d564092abbdc492df6efe8e52866b..69df7ece0b5bada5301ffce846ae154501426841 100644
--- a/chrome/browser/extensions/extension_proxy_apitest.cc
+++ b/chrome/browser/extensions/extension_proxy_apitest.cc
@@ -169,9 +169,8 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyFixedIndividual) {
}
// Tests setting values only for incognito mode
-// TODO(battre): re-enable when incognito is supported again
IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest,
- DISABLED_ProxyFixedIndividualIncognitoOnly) {
+ ProxyFixedIndividualIncognitoOnly) {
ASSERT_TRUE(RunExtensionTestIncognito("proxy/individual_incognito_only")) <<
message_;
const Extension* extension = GetSingleLoadedExtension();
@@ -193,9 +192,8 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest,
}
// Tests setting values also for incognito mode
-// TODO(battre): re-enable when incognito is supported again
IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest,
- DISABLED_ProxyFixedIndividualIncognitoAlso) {
+ ProxyFixedIndividualIncognitoAlso) {
ASSERT_TRUE(RunExtensionTestIncognito("proxy/individual_incognito_also")) <<
message_;
const Extension* extension = GetSingleLoadedExtension();
« chrome/browser/extensions/extension_pref_value_map.cc ('K') | « chrome/browser/extensions/extension_prefs_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698