Support persistent incognito preferences

chrome/browser/extensions/extension_pref_value_map.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_PREF_VALUE_MAP_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_PREF_VALUE_MAP_H_
 #pragma once
 
 #include <map>
 #include <set>
 #include <string>
 
 #include "base/time.h"
 #include "chrome/browser/prefs/value_map_pref_store.h"
+#include "chrome/browser/extensions/extension_prefs_scope.h"

[Matt Perry, 2011/05/24 18:23:24]

I don't see this file in the CL.

[battre, 2011/05/24 18:24:59]

Done.

 
 // Non-persistent data container that is shared by ExtensionPrefStores. All
 // extension pref values (incognito and regular) are stored herein and
 // provided to ExtensionPrefStores.
 //
 // The semantics of the ExtensionPrefValueMap are:
 // - The precedence of extensions is determined by their installation time.
 //   The extension that has been installed later takes higher precedence.
 // - If two extensions set a value for the same preference, the following
 //   rules determine which value becomes effective (visible).
@@ skipping 38 matching lines @@
   ExtensionPrefValueMap();
   virtual ~ExtensionPrefValueMap();
 
   // Set an extension preference |value| for |key| of extension |ext_id|.
   // Takes ownership of |value|.
   // Note that regular extension pref values need to be reported to
   // incognito and to regular ExtensionPrefStores.
   // Precondition: the extension must be registered.
   void SetExtensionPref(const std::string& ext_id,
                         const std::string& key,
-                        bool incognito,
+                        extension_prefs_scope::Scope scope,
                         Value* value);
 
   // Remove the extension preference value for |key| of extension |ext_id|.
   // Precondition: the extension must be registered.
   void RemoveExtensionPref(const std::string& ext_id,
                            const std::string& key,
-                           bool incognito);
+                           extension_prefs_scope::Scope scope);
 
   // Returns true if currently no extension with higher precedence controls the
   // preference.
   // Note that the this function does does not consider the existence of
   // policies. An extension is only really able to control a preference if
   // PrefService::Preference::IsExtensionModifiable() returns true as well.
   bool CanExtensionControlPref(const std::string& extension_id,
                                const std::string& pref_key,
                                bool incognito) const;
 
@@ skipping 29 matching lines @@
 
   const Value* GetEffectivePrefValue(const std::string& key,
                                      bool incognito,
                                      bool* from_incognito) const;
 
  private:
   struct ExtensionEntry;
 
   typedef std::map<std::string, ExtensionEntry*> ExtensionEntryMap;
 
-  const PrefValueMap* GetExtensionPrefValueMap(const std::string& ext_id,
-                                               bool incognito) const;
+  const PrefValueMap* GetExtensionPrefValueMap(
+      const std::string& ext_id,
+      extension_prefs_scope::Scope scope) const;
 
-  PrefValueMap* GetExtensionPrefValueMap(const std::string& ext_id,
-                                         bool incognito);
+  PrefValueMap* GetExtensionPrefValueMap(
+      const std::string& ext_id,
+      extension_prefs_scope::Scope scope);
 
   // Returns all keys of pref values that are set by the extension of |entry|,
   // regardless whether they are set for incognito or regular pref values.
   void GetExtensionControlledKeys(const ExtensionEntry& entry,
                                   std::set<std::string>* out) const;
 
   // Returns an iterator to the extension which controls the preference |key|.
   // If |incognito| is true, looks at incognito preferences first. In that case,
   // if |from_incognito| is not NULL, it is set to true if the effective pref
   // value is coming from the incognito preferences, false if it is coming from
@@ skipping 11 matching lines @@
   // preferences values (i.e. the ones with the highest precedence)
   // are stored in ExtensionPrefStores.
   ExtensionEntryMap entries_;
 
   ObserverList<Observer, true> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionPrefValueMap);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_PREF_VALUE_MAP_H_