Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 7065030: Add missing test to WeakPtr (Closed)

Created:
9 years, 7 months ago by cpu%chromium.org
Modified:
9 years, 7 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add missing test to WeakPtr I discovered we have a weak pointer now and in my quest to understand how it works I spotted case that was not tested: 1) ctor weakptr a 2) ctor factory f 3) ctor weakptr b 4) dtor weakptr b 5) dtor factory f 6) test a Mostly because I thought I saw a mistake but alas it works as-is but still the test is missing. BUG=none TEST= this is a test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86526

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M base/memory/weak_ptr_unittest.cc View 1 chunk +14 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
cpu_(ooo_6.6-7.5)
9 years, 7 months ago (2011-05-24 18:32:07 UTC) #1
willchan no longer on Chromium
9 years, 7 months ago (2011-05-24 22:29:24 UTC) #2
LGTM

http://codereview.chromium.org/7065030/diff/1/base/memory/weak_ptr_unittest.cc
File base/memory/weak_ptr_unittest.cc (right):

http://codereview.chromium.org/7065030/diff/1/base/memory/weak_ptr_unittest.c...
base/memory/weak_ptr_unittest.cc:90: WeakPtr<int> b = factory.GetWeakPtr();
Maybe you should also add EXPECTs for b? Up to you.

Powered by Google App Engine
This is Rietveld 408576698