Add mayHaveChangedRenderedSize callback.

Add mayHaveChangedRenderedSize callback.

BUG=44850
TEST=None as it isn't yet called anywhere.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86581

[levin, 2011-05-24 17:58:47]

The 1st of several patches to switch chromium off of polling for changes in
preferred height.

This simply adds the callback for WebKit to call when the preferred height may
have changed. 

Once the new callback is being called, I will remove the polling and the other
callback.

[jamesr, 2011-05-24 20:31:25]

http://codereview.chromium.org/7065029/diff/1002/content/renderer/render_view.cc
File content/renderer/render_view.cc (right):

http://codereview.chromium.org/7065029/diff/1002/content/renderer/render_view...
content/renderer/render_view.cc:2719: check_preferred_size_timer_.Stop();
shouldn't this have the checks in CheckPreferredSize() (i.e.
send_preferred_size_changes_ && webview())?  Otherwise this is going to be
setting a _ton_ of timers

[levin, 2011-05-24 22:48:15]

On 2011/05/24 20:31:25, jamesr wrote:
>
http://codereview.chromium.org/7065029/diff/1002/content/renderer/render_view.cc
> File content/renderer/render_view.cc (right):
> 
>
http://codereview.chromium.org/7065029/diff/1002/content/renderer/render_view...
> content/renderer/render_view.cc:2719: check_preferred_size_timer_.Stop();
> shouldn't this have the checks in CheckPreferredSize() (i.e.
> send_preferred_size_changes_ && webview())?  Otherwise this is going to be
> setting a _ton_ of timers

Fixed. Plus I added a stop for the timer that I'm starting (as you aren't
support to call start on a running timer but you may call stop on a timer that
isn't running).

[jamesr, 2011-05-24 22:53:33]

lgtm

http://codereview.chromium.org/7065029/diff/5001/content/renderer/render_view.cc
File content/renderer/render_view.cc (right):

http://codereview.chromium.org/7065029/diff/5001/content/renderer/render_view...
content/renderer/render_view.cc:2724:
preferred_size_change_timer_.Start(TimeDelta::FromMilliseconds(10), this,
based on what base/timer.h says i think this Stop/Start() should be a Reset()

[levin, 2011-05-24 23:00:22]

http://codereview.chromium.org/7065029/diff/5001/content/renderer/render_view.cc
File content/renderer/render_view.cc (right):

http://codereview.chromium.org/7065029/diff/5001/content/renderer/render_view...
content/renderer/render_view.cc:2724:
preferred_size_change_timer_.Start(TimeDelta::FromMilliseconds(10), this,
On 2011/05/24 22:53:33, jamesr wrote:
> based on what base/timer.h says i think this Stop/Start() should be a Reset()

Good catch. I missed that call actually, but I don't think it works in this
case.

It appears to only works if the timer is running. (Also this is called the first
time the timer is set-up.)

[commit-bot: I haz the power, 2011-05-25 07:49:39]

Change committed as 86581