Issue 7065017: mediaplayer: trigger hardware acceleration closer to players

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7065017: mediaplayer: trigger hardware acceleration closer to players (Closed)

Created:
9 years, 7 months ago by ilja

Modified:
9 years, 7 months ago

Reviewers:
marcheu, zel

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org, tbarzic

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

mediaplayer: trigger hardware acceleration closer to player This is a workaround for a regression to fix the missing video in the MediaPlayer as reported in bug 15310. It is a followup to http://codereview.chromium.org/6969027/ BUG=chromium-os:15310 TEST=ran manually to see the video Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86539

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/resources/file_manager/slideshow.html	View		2 chunks	+1 line, -1 line	0 comments	Download
	M	chrome/browser/resources/mediaplayer.html	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ilja

This change is mostly for tracking as I am still waiting for Chromium committer rights, ...

9 years, 7 months ago (2011-05-24 02:37:55 UTC) #1

marcheu

On 2011/05/24 02:37:55, ihf wrote: > This change is mostly for tracking as I am ...

9 years, 7 months ago (2011-05-24 02:39:29 UTC) #2

zel

On 2011/05/24 02:39:29, marcheu wrote: > On 2011/05/24 02:37:55, ihf wrote: > > This change ...

9 years, 7 months ago (2011-05-24 16:47:39 UTC) #3

ilja

9 years, 7 months ago (2011-05-25 01:02:35 UTC) #4

On 2011/05/24 16:47:39, zel wrote:
> On 2011/05/24 02:39:29, marcheu wrote:
> > On 2011/05/24 02:37:55, ihf wrote:
> > > This change is mostly for tracking as I am still waiting for Chromium
> > committer
> > > rights, so won't be able to push it.
> > 
> > Please add to the description that this regressed somehow and that we are
> doing
> > a workaround here.
> 
> LGTM

Toni committed it for me under
http://src.chromium.org/viewvc/chrome?view=rev&revision=86539

Expand Messages | Collapse Messages