Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 7065016: Fix pyauto launcher for chromeos (Closed)

Created:
9 years, 7 months ago by Nirnimesh
Modified:
9 years, 7 months ago
Reviewers:
dtu
CC:
chromium-reviews, Paweł Hajdan Jr., krisr
Visibility:
Public.

Description

Fix pyauto launcher for chromeos PyAuto login automation is broken such that it crashes the browser in cases where the ownership is not taken and you don't wait long enough for chrome to startup, login dialog to show, etc. It takes time for chrome to sink these in. For this reason pyauto tests on autotest lab machines were failing (the autotest lab machines begin with a clean stateful partition, and then we trigger a session_manager restart after creating enable_chromium_minidumps file) This CL fixes the launcher. The Login() automation still needs to be fixed to be resilient to the login dialog to show up. BUG=chromium-os:15582 TEST=pyauto test fire up on chromeos autotest lab machines Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86493

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -31 lines) Patch
M chrome/test/chromeos/autotest/files/client/site_tests/desktopui_PyAutoFunctionalTests/desktopui_PyAutoFunctionalTests.py View 1 2 4 chunks +18 lines, -31 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nirnimesh
9 years, 7 months ago (2011-05-24 02:26:56 UTC) #1
dtu
9 years, 7 months ago (2011-05-24 21:05:59 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698