Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2396)

Unified Diff: chrome/browser/download/download_manager.h

Issue 7065015: For downloads requiring a user gesture, also require... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_manager.h
===================================================================
--- chrome/browser/download/download_manager.h (revision 86341)
+++ chrome/browser/download/download_manager.h (working copy)
@@ -204,8 +204,6 @@
Profile* profile() { return profile_; }
- DownloadHistory* download_history() { return download_history_.get(); }
-
DownloadPrefs* download_prefs() { return download_prefs_.get(); }
// Creates the download item. Must be called on the UI thread.
@@ -237,9 +235,17 @@
// Called when the user has validated the download of a dangerous file.
void DangerousDownloadValidated(DownloadItem* download);
+ // Callback function after we check whether the referrer URL has been visited
+ // before today.
+ void CheckVisitedBeforeDone(int32 download_id, bool visited_before);
Randy Smith (Not in Mondays) 2011/05/24 18:28:25 I don't understand the meaning of |visited_before|
Peter Kasting 2011/05/24 20:55:00 I added the word "referrer" to the function and ar
+
// Callback function after url is checked with safebrowsing service.
void CheckDownloadUrlDone(int32 download_id, bool is_dangerous_url);
+ // Called by both the above CheckXXX() functions, proceeds once both checks
+ // have completed.
+ void HistoryAndSBChecksMaybeDone(DownloadItem* download);
+
// Callback function after download file hash is checked with safebrowsing
// service.
void CheckDownloadHashDone(int32 download_id, bool is_dangerous_hash);

Powered by Google App Engine
This is Rietveld 408576698