For downloads requiring a user gesture, also require...

chrome/browser/download/download_item.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Each download is represented by a DownloadItem, and all DownloadItems
 // are owned by the DownloadManager which maintains a global list of all
 // downloads. DownloadItems are created when a user initiates a download,
 // and exist for the duration of the browser life time.
 //
 // Download observers:
@@ skipping 259 matching lines @@
   bool is_paused() const { return is_paused_; }
   bool open_when_complete() const { return open_when_complete_; }
   void set_open_when_complete(bool open) { open_when_complete_ = open; }
   SafetyState safety_state() const { return safety_state_; }
   void set_safety_state(SafetyState safety_state) {
     safety_state_ = safety_state;
   }
   // Why |safety_state_| is not SAFE.
   DangerType GetDangerType() const;
   bool IsDangerous() const;
-  void MarkUrlDangerous();
+  void SetFileDangerous(bool dangerous);

[Randy Smith (Not in Mondays), 2011/05/24 18:28:25]

This accessor doesn't look like it's used outside of tests.  Could we get rid of
it?

[Peter Kasting, 2011/05/24 20:55:00]

You're right that it's only used in tests, but how can I get rid of it?  Do you
want me to add friend declarations to this class?

[Randy Smith (Not in Mondays), 2011/05/24 21:48:56]

You could use SetFileCheckResults based on a DownloadStateInfo structure; that's
the way that it gets set in normal processing.  But that would probably take
some re-working of the test, and I think the reason for this accessor is that
you're getting rid of superfluous members in DownloadCreateInfo, which is gravy
from my point of view even with the extra accessor in DownloadItem, so don't
worry about it unless you feel an urge to do the extra cleanup.

+  void SetUrlDangerous(bool dangerous);

[Randy Smith (Not in Mondays), 2011/05/24 18:28:25]

This may be an area where we disagree, but I'm trying to limit the "bag of bits"
feeling about the DownloadItem, and hence I'd rather have exposed as accessor
only the state transition that the item actually undergoes.  So (assuming you
can get rid of the TriState enum as per my other comment) would you be willing
to make this accessor only do the transition from safe to dangerous?

+  void SetVisitedBefore(bool visited_referrer_before);

[Randy Smith (Not in Mondays), 2011/05/24 18:28:25]

Similarly, could you drop the argument and just call this if you need to mark
the DownloadItem as visited before?  (Or not visited before; I don't care what
the default state is.)

 
   bool auto_opened() { return auto_opened_; }
   FilePath target_name() const { return state_info_.target_name; }
   bool save_as() const { return state_info_.prompt_user_for_save_location; }
   bool is_otr() const { return is_otr_; }
   bool is_extension_install() const {
     return state_info_.is_extension_install;
   }
   FilePath suggested_path() const { return state_info_.suggested_path; }
   bool is_temporary() const { return is_temporary_; }
@@ skipping 135 matching lines @@
   // Did the user open the item either directly or indirectly (such as by
   // setting always open files of this type)? The shelf also sets this field
   // when the user closes the shelf before the item has been opened but should
   // be treated as though the user opened it.
   bool opened_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadItem);
 };
 
 #endif  // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_H_